Adds Makefile Targets for API and UI and Updates the pre-submit PR script #277

PuneetPunamiya · 2021-06-11T13:17:20Z

This patch adds a Makefile targets for
- API: Unit Test, Lint, Build, Update Golden files
- UI: Unit Test, Lint, Build
- Yamllint check

$ make help    
test                 run all Unit Tests
lint                 check all Lints
api-check            all API checks
ui-check             all UI checks
goa-gen              generate API Design
generated            update the golden files
api-lint             run API Lint
api-test             run API Unit Test
api-build            generate the API binary
ui-lint              run UI Lint
ui-test              run UI Unit Test
ui-build             generate the UI binary
yaml-lint            run YAML Lint
help                 print this help

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Commit messages follow commit message best practices

See the contribution guide for more details.

sm43 · 2021-06-14T05:23:04Z

could you document the command available through make file and what they do?

PuneetPunamiya · 2021-06-14T08:20:04Z

could you document the command available through make file and what they do?

Where that file should be located ??

sm43 · 2021-06-14T10:14:32Z

could you document the command available through make file and what they do?

Where that file should be located ??

Development.md
also if we have a command which does goa gen - run unit test - lint and everything needed before creating pr
we can add that in pr template similar to tkn cli

PuneetPunamiya · 2021-06-16T05:59:21Z

could you document the command available through make file and what they do?

Where that file should be located ??

Development.md
also if we have a command which does goa gen - run unit test - lint and everything needed before creating pr
we can add that in pr template similar to tkn cli

Sounds good will update the pr thanks 👍🏻

vinamra28 · 2021-06-16T14:17:25Z

test/presubmit-tests.sh


-  CI=true npm test || {
+  make ui-test || {


why are we removing CI=true ?

I have added that in the specified make target
For e.g.

# Make target for UI Unit Test .PHONY: ui-test ui-test: @echo "----------------------------" @echo "-- Running UI Unit Tests --" @echo "----------------------------" cd ui && npm clean-install && CI=true npm test

test/presubmit-tests.sh

vinamra28 · 2021-06-21T10:51:19Z

should we add make help as well which can list all possible subcommands?

vinamra28 · 2021-06-21T11:22:34Z

/lgtm

vinamra28 · 2021-07-01T06:55:17Z

/lgtm

.github/pull_request_template.md

sm43 · 2021-07-01T09:23:24Z

Makefile

+	@echo "----------------------------"
+	@echo "- Generating v1 API Design... "
+	@echo "----------------------------"
+	cd api && cd v1 && goa gen github.com/tektoncd/hub/api/v1/design


how does this work?
cd api && goa gen github.com/tektoncd/hub/api/design
when we do this.. does the directory context changes only for that command?
and
again below it does
cd api/v1 so each command runs in a separate context/terminal?

Yes the directory content changes only for that command and also the command runs in a separate context

vinamra28 · 2021-07-02T04:43:05Z

/lgtm

sm43 · 2021-07-05T02:49:36Z

api/update.sh

@@ -0,0 +1 @@
+go test $(go list -f '{{ .ImportPath }} {{ .TestImports }}' ./... | grep gotest.tools/v3/golden | awk '{print $1}' | tr '\n' ' ') -test.update-golden=true


does this requires to be in separate file?

yeah I guess.... we can use it independently as well

sm43 · 2021-07-07T10:18:55Z

/approve
/meow

tekton-robot · 2021-07-07T10:18:57Z

@sm43:

In response to this:

/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2021-07-07T10:18:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sm43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sm43]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vinamra28 · 2021-07-07T10:25:01Z

Makefile

+	@echo "----------------------------"
+	@echo "-- Generating Golden Files... --"
+	@echo "----------------------------"
+	cd api && go mod vendor && bash update.sh


Suggested change

cd api && go mod vendor && bash update.sh

cd api && go mod vendor && bash update-golden-files.sh

- This patch adds a Makefile targets for - API: GOA Generation, Unit Test, Lint, Build, Update Golden files - UI: Unit Test, Lint, Build - Yamllint check Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>

Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>

vinamra28 · 2021-07-07T10:31:36Z

/lgtm

tekton-robot requested review from sm43 and sthaha June 11, 2021 13:17

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 11, 2021

PuneetPunamiya force-pushed the makefile branch from c1165f2 to 189e91a Compare June 11, 2021 13:21

PuneetPunamiya force-pushed the makefile branch from 189e91a to 5618e4a Compare June 16, 2021 14:14

vinamra28 reviewed Jun 16, 2021

View reviewed changes

PuneetPunamiya force-pushed the makefile branch from 5618e4a to c1adeb2 Compare June 21, 2021 11:19

tekton-robot assigned vinamra28 Jun 21, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021

PuneetPunamiya force-pushed the makefile branch from c1adeb2 to b999a3d Compare June 30, 2021 14:05

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2021

sm43 reviewed Jul 1, 2021

View reviewed changes

.github/pull_request_template.md Outdated Show resolved Hide resolved

sm43 reviewed Jul 1, 2021

View reviewed changes

PuneetPunamiya force-pushed the makefile branch from b999a3d to be055c6 Compare July 1, 2021 12:13

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021

sm43 reviewed Jul 5, 2021

View reviewed changes

PuneetPunamiya force-pushed the makefile branch from be055c6 to e3f6ff8 Compare July 7, 2021 10:14

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021

vinamra28 reviewed Jul 7, 2021

View reviewed changes

PuneetPunamiya added 2 commits July 7, 2021 15:58

Adds Makefile and call the make functions in pre-submit

876d837

- This patch adds a Makefile targets for - API: GOA Generation, Unit Test, Lint, Build, Update Golden files - UI: Unit Test, Lint, Build - Yamllint check Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>

Updates the PR template by adding make targets

cd11c64

Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>

PuneetPunamiya force-pushed the makefile branch from e3f6ff8 to cd11c64 Compare July 7, 2021 10:28

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021

tekton-robot merged commit 9f05851 into tektoncd:main Jul 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Makefile Targets for API and UI and Updates the pre-submit PR script #277

Adds Makefile Targets for API and UI and Updates the pre-submit PR script #277

PuneetPunamiya commented Jun 11, 2021 •

edited

Loading

sm43 commented Jun 14, 2021

PuneetPunamiya commented Jun 14, 2021

sm43 commented Jun 14, 2021 •

edited

Loading

PuneetPunamiya commented Jun 16, 2021

vinamra28 Jun 16, 2021

PuneetPunamiya Jun 16, 2021

vinamra28 commented Jun 21, 2021

vinamra28 commented Jun 21, 2021

vinamra28 commented Jul 1, 2021

sm43 Jul 1, 2021

PuneetPunamiya Jul 1, 2021

vinamra28 commented Jul 2, 2021

sm43 Jul 5, 2021

vinamra28 Jul 5, 2021

sm43 commented Jul 7, 2021

tekton-robot commented Jul 7, 2021

tekton-robot commented Jul 7, 2021

vinamra28 Jul 7, 2021

vinamra28 commented Jul 7, 2021

		@@ -0,0 +1 @@
		go test $(go list -f '{{ .ImportPath }} {{ .TestImports }}' ./... \| grep gotest.tools/v3/golden \| awk '{print $1}' \| tr '\n' ' ') -test.update-golden=true

	cd api && go mod vendor && bash update.sh
	cd api && go mod vendor && bash update-golden-files.sh

Adds Makefile Targets for API and UI and Updates the pre-submit PR script #277

Adds Makefile Targets for API and UI and Updates the pre-submit PR script #277

Conversation

PuneetPunamiya commented Jun 11, 2021 • edited Loading

Changes

Submitter Checklist

sm43 commented Jun 14, 2021

PuneetPunamiya commented Jun 14, 2021

sm43 commented Jun 14, 2021 • edited Loading

PuneetPunamiya commented Jun 16, 2021

vinamra28 Jun 16, 2021

Choose a reason for hiding this comment

PuneetPunamiya Jun 16, 2021

Choose a reason for hiding this comment

vinamra28 commented Jun 21, 2021

vinamra28 commented Jun 21, 2021

vinamra28 commented Jul 1, 2021

sm43 Jul 1, 2021

Choose a reason for hiding this comment

PuneetPunamiya Jul 1, 2021

Choose a reason for hiding this comment

vinamra28 commented Jul 2, 2021

sm43 Jul 5, 2021

Choose a reason for hiding this comment

vinamra28 Jul 5, 2021

Choose a reason for hiding this comment

sm43 commented Jul 7, 2021

tekton-robot commented Jul 7, 2021

tekton-robot commented Jul 7, 2021

vinamra28 Jul 7, 2021

Choose a reason for hiding this comment

vinamra28 commented Jul 7, 2021

PuneetPunamiya commented Jun 11, 2021 •

edited

Loading

sm43 commented Jun 14, 2021 •

edited

Loading