Updates the Response of Resources API's by adding array of Categories #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
size/XXL
pratap0007
reviewed
Jun 15, 2021
PuneetPunamiya
force-pushed
the
left-resources-update
branch
from
df32c1d to
cd18f08
Compare
tekton-robot
added
size/L
|
/lgtm |
|
/lgtm |
- This patch updates the design of Resources by adding
an array of Categories for the following API's
- /resource/{catalog}/{kind}/{name}/{version}
- /resource/version/{versionId}
- Updates the resources tests which adds category array in the
response of CatalogKindNameVersion and ResourceBYVersionID
Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
…ries
- This patch updates the design of Resources by adding
an array of Categories for the following API's
- /v1/resource/{catalog}/{kind}/{name}/{version}
- /v1/resource/version/{versionId}
- Updates the v1 resources tests which adds category array in the
response of CatalogKindNameVersion and ResourceBYVersionID
Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
PuneetPunamiya
force-pushed
the
left-resources-update
branch
from
cd18f08 to
480a06d
Compare
|
/lgtm |
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sm43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the design of Resources by adding
an array of Categories for the following API's
Updates the resources tests which adds category array in the
response of CatalogKindNameVersion and ResourceBYVersionID
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.