-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment doc for disconnected cluster #272
Conversation
## Deploying on Disconnected Cluster | ||
|
||
- To deploy on a disconnected cluster you need to fork the [tektoncd/catalog][catalog] or you can use your own catalog but it must follow the [Catalog TEP][catalog-tep]. | ||
- Fork the tektoncd/hub and update the [hub config][hub-config] file for your catalog details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add/explain more or add an example of block of what needs to be updated in the config file ?
docs/DEPLOYMENT.md
Outdated
|
||
- To deploy on a disconnected cluster you need to fork the [tektoncd/catalog][catalog] or you can use your own catalog but it must follow the [Catalog TEP][catalog-tep]. | ||
- Fork the tektoncd/hub and update the [hub config][hub-config] file for your catalog details. | ||
- Mirror the Hub Images to the registry disconnected cluster has access to. You can use release images or build your own. you can use the latest release tag as the image tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please reframe this ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be nice to point to the Build Image
section of the deployment docs ??
docs/DEPLOYMENT.md
Outdated
- Fork the tektoncd/hub and update the [hub config][hub-config] file for your catalog details. | ||
- Mirror the Hub Images to the registry disconnected cluster has access to. You can use release images or build your own. you can use the latest release tag as the image tag. | ||
- List of images to be mirrored | ||
- quay.io/tekton-hub/ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
- quay.io/tekton-hub/ui | |
UI - quay.io/tekton-hub/ui |
@@ -428,6 +429,19 @@ curl -X POST -H "Authorization: <access-token>" \ | |||
``` | |||
Replace `<access-token>` with your JWT token. you must have `config-refresh` scope to call this API. | |||
|
|||
## Deploying on Disconnected Cluster | |||
|
|||
- To deploy on a disconnected cluster you need to fork the [tektoncd/catalog][catalog] or you can use your own catalog but it must follow the [Catalog TEP][catalog-tep]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess without forking also we can use tektoncd/catalog in hub right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we? disconnected cluster. they need to have a catalog in their env? right?
docs/DEPLOYMENT.md
Outdated
|
||
- To deploy on a disconnected cluster you need to fork the [tektoncd/catalog][catalog] or you can use your own catalog but it must follow the [Catalog TEP][catalog-tep]. | ||
- Fork the tektoncd/hub and update the [hub config][hub-config] file for your catalog details. | ||
- Mirror the Hub Images to the registry disconnected cluster has access to. You can use release images or build your own. you can use the latest release tag as the image tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please mention the step of how to do mirroring
- quay.io/tekton-hub/api | ||
- quay.io/tekton-hub/db-migration | ||
- postgres:13@sha256:260a98d976574b439712c35914fdcb840755233f79f3e27ea632543f78b7a21e | ||
- Now, follow the steps from [Deploy Database Section](#deploy-database) above. Make sure you update the images in deployment files before applying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please mention, how the URLs will look like after mirroring for images
Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
/lgtm |
/approve |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.