Adds an ingress to redirect from Hub Preview to Hub

[PuneetPunamiya]

• This patch adds an annotation which redirects from Hub Preview to Hub as
  nginx.ingress.kubernetes.io/permanent-redirect: https://hub.tekton.dev

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Commit messages follow commit message best practices

See the contribution guide for more details.

[piyush-garg]

/cc @afrittoli Will be great if you can review

[tekton-robot]

@piyush-garg: GitHub didn't allow me to request PR reviews from the following users: can, review, Will, be, great, if, you.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @afrittoli Will be great if you can review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afrittoli]

Thank you for this!
Could you include the annotation for the DNS name too?

    dns.gardener.cloud/dnsnames: hub-preview.tekton.dev
    dns.gardener.cloud/ttl: "3600"

I guess it's ok for now to have this in the hub repo but I'd really prefer eventually to separate this out to the plumbing repo - because this is specific to the deployment to dogfooding and anyone installing hub does not really need this ingress at all.

[afrittoli]

I usually include host: hub-preview.tekton.dev as key under rules too, but I'm not 100% sure if it's required:

spec:
  rules:
  - host: hub-preview.tekton.dev
     http: (...)

[PuneetPunamiya]

Sorry for late reply
Is it fine if we apply the ingress on dogfooding first and see and if that works fine then merge the pr ??

[afrittoli]

I tried on the cluster but unfortunately it doesn't work, we'd have to install a separate nginx controller. Using a CNAME record works, as long as the hub ingress is updated to include hub-preview.tekton.dev in the list of hosts.
In that case however there is no HTTP redirect sent to the client, simply the hub production site is served to hub-preview as well

[PuneetPunamiya]

dns.gardener.cloud/dnsnames: hub-preview.tekton.dev
dns.gardener.cloud/ttl: "3600"

Hey @afrittoli I have added this annotation and updated the pr

I tried on the cluster but unfortunately it doesn't work, we'd have to install a separate nginx controller. Using a CNAME record works, as long as the hub ingress is updated to include hub-preview.tekton.dev in the list of hosts.
In that case however there is no HTTP redirect sent to the client, simply the hub production site is served to hub-preview as well

Should we try this on dogfooding once ?? Is there anything more we need to do from Hub Side ??

[afrittoli]

I deployed the nginx ingress controller to dogfooding to watch the tekton-hub-preview namespace only:

helm repo add ingress-nginx https://kubernetes.github.io/ingress-nginx
helm repo update
helm install hub-preview-ingress-nginx ingress-nginx/ingress-nginx --set controller.watchNamespace=tekton-hub-preview --set controller.config.entries.default-server-return="301 https://hub.tekton.dev"

I also deployed this ingress resource, and the redirect works fine:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: redirect-to-tekton-hub
  namespace: tekton-hub-preview
  annotations:
    acme.cert-manager.io/http01-edit-in-place: 'true'
    cert-manager.io/cluster-issuer: letsencrypt-prod
    nginx.ingress.kubernetes.io/permanent-redirect: https://hub.tekton.dev
    nginx.ingress.kubernetes.io/force-ssl-redirect: 'true'
    dns.gardener.cloud/dnsnames: hub-preview.tekton.dev
    dns.gardener.cloud/ttl: '3600'
    kubernetes.io/ingress.class: "nginx"
spec:
  tls:
    - secretName: ui-hub-preview-tekton-dev-tls
      hosts: [hub-preview.tekton.dev]
  rules:
    - host: hub-preview.tekton.dev
      http:
        paths:
          - path: /*
            backend:
              serviceName: ui
              servicePort: 8080

Could you update this PR to match the ingress above ^^^ ?

Thank you!

[PuneetPunamiya]

@afrittoli Thanks a lot for all your help, have updated the pr, could you please take a look at it once

[afrittoli]

Thank you for the updtes!
/lgtm

[sm43]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sm43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sm43]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment