UI: Updates year to current year in the footer #261
Conversation
Signed-off-by: Shiv Verma <shverma@redhat.com>
tekton-robot
added
the
size/S
|
Is it fine to do this? cc @vdemeester |
| @@ -307,7 +307,9 @@ exports[`App should render the component correctly and match the snapshot 1`] = | |||
| <div className=\\"pf-l-grid__item pf-m-12-col hub-footer-description\\"> | |||
| <Text> | |||
| <p data-pf-content={true} className=\\"\\"> | |||
| © 2020 The Linux Foundation®. All rights reserved. The Linux Foundation has registered trademarks and uses trademarks. For a list of trademarks of The Linux Foundation, please see our | |||
| © | |||
| 2021 | |||
There was a problem hiding this comment.
Shouldn't we use new Date().getFullYear() here as well
There was a problem hiding this comment.
I think , we can't do in the snapshot
There was a problem hiding this comment.
So the snapshot will change once the year changes right ??
There was a problem hiding this comment.
I think will not change
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.