Updates query param minpipelinesversion to pipelinesversion in APIs #244
Conversation
tekton-robot
added
the
size/L
sm43
changed the title
| if p.Minpipelinesversion != nil { | ||
| r = filterCompatibleVersions(r, *p.Minpipelinesversion) | ||
| // If pipelinesVersion is passed then check for version compatible with pipelines version | ||
| if p.Pipelinesversion != nil { |
There was a problem hiding this comment.
shouldn't this be p.PipelinesVersion ?
There was a problem hiding this comment.
goa makes it title case P.
for v to be V, query param has to be changed from pipelinesversion to pipelinesVersion :)
sm43
changed the title
|
/lgtm |
|
@sm43 could you please rebase once |
tekton-robot
added
the
needs-rebase
This updates the query param as user would pass piplines version so minPipelinesVersion would not make sense as we use it to refer what version the task is compatible with, hence renames the param. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
This updates the query param as user would pass piplines version so minPipelinesVersion would not make sense as we use it to refer what version the task is compatible with, hence renames the param. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
tekton-robot
removed
lgtm
|
/lgtm |
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pratap0007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Updates for both preview and v1 API and adds tests for regex check
This updates the query param as user would pass piplines version so
minPipelinesVersion would not make sense as we use it to refer what
version the task is compatible with, hence renames the param.
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.