UI: Scroll to top of home page when users click on the Hub logo #243
Conversation
tekton-robot
added
the
size/M
| @@ -0,0 +1,8 @@ | |||
| import { assert } from '../store/utils'; | |||
There was a problem hiding this comment.
Can we add a unit test for this
pratap0007
force-pushed
the
logo-redirect
branch
from
1cc0b3b to
bd1437c
Compare
ui/src/common/scrollToTop.test.ts
Outdated
| import { scrollToTop } from './scrollToTop'; | ||
|
|
||
| describe('Test scrollToTop function', () => { | ||
| it('Test scrollToTop function', () => { |
There was a problem hiding this comment.
| it('Test scrollToTop function', () => { | |
| it('should move the page to top', () => { |
This patch includes following changes - Moves `scrollToTop` function to common folder since it is reusabe - When user clicks on Hub logo it scroll to top of home page if they are on the home page otherwise redirects to home page Signed-off-by: Shiv Verma <shverma@redhat.com>
pratap0007
force-pushed
the
logo-redirect
branch
from
bd1437c to
07fe7c0
Compare
|
Thanks 🤙 |
|
/lgtm |
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This patch includes following changes
scrollToTopfunction to common folder since it is reusabethey are on the home page otherwise redirects to home page
Signed-off-by: Shiv Verma shverma@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.