UI: Fixes to rate a resource #236
Conversation
Previously it was using name to access a resource from store but needs a key(containing resource's name,kind and catalag name) to access it Sigend-off-by: Shiv Verma <shverma@redhat.com>
tekton-robot
added
the
size/S
|
Thanks for the pr 🤙 |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| import './Rating.css'; | ||
|
|
||
| const Rating: React.FC = observer(() => { | ||
| const { name } = useParams(); | ||
| const { name, kind, catalog } = useParams(); | ||
| const resourceKey = `${catalog}/${titleCase(kind)}/${name}`; |
Previously it was using name to access a resource from store but needs
a key(containing resource's name,kind and catalag name) to access it
Sigend-off-by: Shiv Verma shverma@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.