CLI: Respect pipelines version in CLI subcommands #229
Conversation
tekton-robot
added
the
size/XL
|
/retest |
vinamra28
force-pushed
the
vinamra28/check-pipeline-version-in-hub-cli
branch
from
c8aaff9 to
1c86bc7
Compare
|
/retest |
|
/test pull-tekton-hub-integration-tests |
|
/test pull-tekton-hub-unit-tests |
|
/test pull-tekton-hub-integration-tests |
|
/lgtm |
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sm43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
As of now when we do `tkn hub <subcommand> task taskname` without taking care of the version of Tekton Pipelines installed on the cluster and due to this it might break the TaskRun or PipelineRun created by the user if the required Pipelines version is greater than that installed on the cluster. Eg buildah 0.2 requires pipelines minVersion to be 0.17.0 and we have 0.16.3 installed on our cluster so when running this task it will break. With this patch we will respect the min version required to run the task which we get from the annotation present in the task as pipelines.minVersion and the installed pipelines version. - If the installed pipelines version is greater than pipelines.minVersion value then the task will be upgraded/downgraded/reinstalled directly. - If the installed pipelines version is lesser than pipelines.minVersion value it will error out. - If the pipelines controller is installed on another namespace other than `tekton-pipelines` and `openshift-pipelines` then it will give the warning and upgrade/downgrade/reinstall the task. Signed-off-by: vinamra28 <vinjain@redhat.com>
vinamra28
force-pushed
the
vinamra28/check-pipeline-version-in-hub-cli
branch
from
1c86bc7 to
4bb3d4c
Compare
|
Thanks 🤙 /lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
As of now when we do
tkn hub <subcommand> task tasknamewithout taking careof the version of Tekton Pipelines installed on the cluster and due to
this it might break the TaskRun or PipelineRun created by the user if
the required Pipelines version is greater than that installed on the
cluster. Eg buildah 0.2 requires pipelines minVersion to be 0.17.0 and
we have 0.16.3 installed on our cluster so when running this task it
will break.
With this patch we will respect the min version required to run the task
which we get from the annotation present in the task as
pipelines.minVersion and the installed pipelines version.
then the task will be upgraded/downgraded/reinstalled directly.
value it will error out.
than
tekton-pipelinesandopenshift-pipelinesthen it will give thewarning and upgrade/downgrade/reinstall the task.
Signed-off-by: vinamra28 vinjain@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.