Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Goa Version and Update Hub API server url from http --> https #228

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Bump Goa Version and Update Hub API server url from http --> https #228

merged 2 commits into from
Apr 5, 2021

Conversation

PuneetPunamiya
Copy link
Member

Changes

  • This patch includes
    • Bumps GOA verson
    • Hub API is hosted as https instead of http so changing
      the application-layer protocol from HTTP to HTTPS

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot requested review from sm43 and sthaha March 31, 2021 08:13
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 31, 2021
@sm43
Copy link
Member

sm43 commented Mar 31, 2021

go mod tidy?

@PuneetPunamiya
Bump goa version
66604c2 
Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
@PuneetPunamiya
Change api server url from http --> https
b304bda 
  - Hub API is hosted as `https` instead of `http` so changing
    the application-layer protocol from HTTP to HTTPS

Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
@PuneetPunamiya
Copy link
Member Author

/retest

@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-hub-integration-tests

@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-hub-unit-tests

@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-hub-integration-tests

1 similar comment
@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-hub-integration-tests

@sm43
Copy link
Member

sm43 commented Mar 31, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021
@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-hub-integration-tests

1 similar comment
@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-hub-integration-tests

@piyush-garg
Copy link
Contributor

/lgtm

@pratap0007
Copy link
Contributor

/lgtm
/meow

@tekton-robot
Copy link

@pratap0007: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pratap0007
Copy link
Contributor

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pratap0007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2021
@tekton-robot tekton-robot merged commit c63ae4f into tektoncd:main Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm43 sm43 Awaiting requested review from sm43

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@piyush-garg piyush-garg

@pratap0007 pratap0007

@sm43 sm43

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PuneetPunamiya @sm43 @piyush-garg @pratap0007 @tekton-robot