Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds catalog name in hub cli search command #223

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Adds catalog name in hub cli search command #223

merged 1 commit into from
Mar 28, 2021

Conversation

PuneetPunamiya
Copy link
Member

  • This patch displays the name of the catalog from which
    the resource is on searching the resource using
    tkn hub search <resourceName>
╰─ tkn hub search golang 
NAME                  KIND   CATALOG   DESCRIPTION                                  TAGS
golang-build (0.1)    Task   Tekton    This Task is Golang task to build Go pr...   build-tool
golangci-lint (0.1)   Task   Tekton    This Task is Golang task to validate Go...   lint

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@PuneetPunamiya
Adds catalog name in hub cli search command
2731699 
   - This patch displays the name of the catalog from which
     the resource is on searching the resource using
     `tkn hub search <resourceName>`

Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2021
vinamra28
vinamra28 reviewed Mar 26, 2021
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
@vinamra28
Copy link
Member

/retest

1 similar comment
@PuneetPunamiya
Copy link
Member Author

/retest

@sm43
Copy link
Member

sm43 commented Mar 28, 2021

/approve
/meow

@tekton-robot
Copy link

@sm43: cat image

In response to this:

/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SM43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2021
@tekton-robot tekton-robot merged commit 48bff7a into tektoncd:main Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@pratap0007 pratap0007 Awaiting requested review from pratap0007

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PuneetPunamiya @vinamra28 @sm43 @tekton-robot