Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds doc defining steps to add new catalog in Hub #209

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Adds doc defining steps to add new catalog in Hub #209

merged 1 commit into from
Mar 23, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Mar 5, 2021

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 5, 2021
@sm43 sm43 force-pushed the add-new-catalog-doc branch from b648ae7 to f798f68 Compare March 5, 2021 03:34
vinamra28
vinamra28 reviewed Mar 5, 2021
View reviewed changes
docs/ADD_NEW_CATALOG.md Outdated Show resolved Hide resolved
@sm43 sm43 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2021
@sm43 sm43 force-pushed the add-new-catalog-doc branch from f798f68 to 6c5f365 Compare March 11, 2021 02:41
Base automatically changed from master to main March 18, 2021 16:08
@sm43 sm43 force-pushed the add-new-catalog-doc branch from 6c5f365 to 79383d4 Compare March 22, 2021 05:00
@sm43 sm43 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2021
@piyush-garg
Copy link
Contributor

/lgtm

@sm43
Copy link
Member Author

sm43 commented Mar 23, 2021

/retest

Adds doc defining steps to add new catalog in Hub
ac1ee63 
This adds a doc which defines the steps to add a new catalog in Hub.
Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 force-pushed the add-new-catalog-doc branch from 79383d4 to ac1ee63 Compare March 23, 2021 05:08
vinamra28
vinamra28 reviewed Mar 23, 2021
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@PuneetPunamiya
Copy link
Member

/approve
/woof
/meow

@tekton-robot
Copy link

@PuneetPunamiya: dog image

In response to this:

/approve
/woof
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/approve
/woof
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
@tekton-robot tekton-robot merged commit 550e918 into tektoncd:main Mar 23, 2021
@sm43 sm43 deleted the add-new-catalog-doc branch April 15, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@sthaha sthaha Awaiting requested review from sthaha

@vdemeester vdemeester Awaiting requested review from vdemeester

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sm43 @piyush-garg @PuneetPunamiya @tekton-robot @vinamra28