Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates catalog refresh API to refresh by its name #204

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Updates catalog refresh API to refresh by its name #204

merged 1 commit into from
Mar 23, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Mar 3, 2021

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2021
@sm43 sm43 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2021
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2021
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2021
@pratap0007
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2021
Base automatically changed from master to main March 18, 2021 16:08
@tekton-robot
Copy link

tekton-robot commented Mar 18, 2021 •
edited
Loading

@sm43: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-hub-build-tests bcd6590 link /test pull-tekton-hub-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2021
@sm43 sm43 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2021
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2021
Updates catalog refresh API to refresh catalog by its name
0b1bd02 
This updates the API to refresh a catalog by its name, previously
it use to fetch first catalog from db and refresh it. user will pass
name of catalog and that catalog will be refreshed if exists.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@PuneetPunamiya
Copy link
Member

/approve
/meow
/woof

@tekton-robot
Copy link

@PuneetPunamiya: dog image

In response to this:

/approve
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/approve
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@tekton-robot tekton-robot merged commit ac32a6e into tektoncd:main Mar 23, 2021
@sm43 sm43 deleted the multi-catalog branch March 23, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg left review comments

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vinamra28 vinamra28

@pratap0007 pratap0007

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sm43 @pratap0007 @tekton-robot @piyush-garg @PuneetPunamiya @vinamra28