UI: Adds a button to clear all selected filters #197
Conversation
tekton-robot
added
the
size/L
pratap0007
force-pushed
the
clear-filter
branch
from
e52aece to
9cec332
Compare
pratap0007
changed the title
pratap0007
force-pushed
the
clear-filter
branch
from
9cec332 to
843b6bf
Compare
pratap0007
force-pushed
the
clear-filter
branch
from
843b6bf to
ac3be3e
Compare
| const checkResources = (resources: IResource[]) => { | ||
| return !resources.length ? ( | ||
| const checkResources = (resourceList: IResource[]) => { | ||
| return !resourceList.length ? ( |
There was a problem hiding this comment.
Could you please consider writing a unit test for different conditions ??
There was a problem hiding this comment.
I guess for that there is a test already
There was a problem hiding this comment.
I think there is test for empty state, I guess we need to write for Clear All Filters as well
pratap0007
force-pushed
the
clear-filter
branch
4 times, most recently
from
18865b0 to
55d5f47
Compare
|
/lgtm |
This patch adds following - adds an action in resource store to clear all selected filters - adds a button on `No Resource Found` page Signed-off-by: Shiv Verma <shverma@redhat.com>
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This patch adds following
No Resource FoundpageSigned-off-by: Shiv Verma shverma@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.