Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Validates resource details page url's params #195

Merged
merged 1 commit into from
Mar 2, 2021
Merged

UI: Validates resource details page url's params #195

merged 1 commit into from
Mar 2, 2021

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Feb 17, 2021 •
edited
Loading 

If url's params(resource name,resource kind name, resource catalog name)
of details page is valid then it redirects to details page otherwise
to the PageNotFound

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot requested review from sm43 and sthaha February 17, 2021 11:11
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 17, 2021
@pratap0007 pratap0007 force-pushed the validate-url branch 2 times, most recently from 546f8c4 to 69c48e7 Compare February 23, 2021 10:10
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 23, 2021
@PuneetPunamiya
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
vinamra28
vinamra28 reviewed Mar 1, 2021
View reviewed changes
ui/src/components/PageNotFound/index.tsx Outdated Show resolved Hide resolved
ui/src/containers/Details/Details.test.tsx Show resolved Hide resolved
ui/src/containers/Details/index.tsx Outdated Show resolved Hide resolved
@pratap0007
Validates resource details page url's params
4611685 
If url's params(resource name,resource kind name, resource catalog name)
of details page is valid then it redirects to details page otherwise
to the PageNotFound

Signed-off-by: Shiv Verma <shverma@redhat.com>
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2021
@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2021
@PuneetPunamiya
Copy link
Member

/approve
/meow
/woof

@tekton-robot
Copy link

@PuneetPunamiya: dog image

In response to this:

/approve
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/approve
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
@tekton-robot tekton-robot merged commit 0b7eedc into tektoncd:master Mar 2, 2021
@snyk-bot snyk-bot mentioned this pull request Sep 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuneetPunamiya PuneetPunamiya PuneetPunamiya left review comments

@vinamra28 vinamra28 vinamra28 left review comments

@sm43 sm43 Awaiting requested review from sm43

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vinamra28 vinamra28

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratap0007 @PuneetPunamiya @vinamra28 @tekton-robot