Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI:Updates packages that have vulnerability #160

Merged
merged 1 commit into from
Feb 12, 2021
Merged

UI:Updates packages that have vulnerability #160

merged 1 commit into from
Feb 12, 2021

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Jan 6, 2021 •
edited
Loading

Changes

This patch updates vulnerable packages and enforces following changes

- Modifies few tests and Resources component
- Adds prettier rule for endOfLine as auto to resolve prettier errors
- Moves global variable declaration into a `.d.ts` file
to resolve eslint errors
- Adds `.eslintcache` in the gitignore which is generated by
latest version of react-scripts

Signed-off-by:Shiv Verma shverma@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 6, 2021
@vinamra28
Copy link
Member

/retest

@pratap0007 pratap0007 force-pushed the update-packages branch 2 times, most recently from 1957160 to 4ae49c7 Compare January 7, 2021 08:10
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2021
PuneetPunamiya
PuneetPunamiya reviewed Feb 9, 2021
View reviewed changes
ui/src/config/constants.tsx Outdated
@@ -3,7 +3,9 @@ interface API_CONFIG {
GH_CLIENT_ID: string;
}

// eslint-disable-next-line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this, I think we should not allow eslint disable

@pratap0007 pratap0007 force-pushed the update-packages branch 3 times, most recently from 3015c30 to 06861c7 Compare February 10, 2021 07:06
@vinamra28
Copy link
Member

@pratap0007 can we have the commit description as well highlighting all the changes in this commit apart from commit message?

@pratap0007
Updates packages that have vulnerability
7bb8273 
This patch updates vulnerable packages and enforces following changes

- Modifies few tests and Resources component
- Adds prettier rule for endOfLine as auto to resolve prettier errors
- Moves global variable declaration into a `.d.ts` file
to resolve eslint errors
- Adds `.eslintcache` in the gitignore which is generated by
latest version of react-scripts

Signed-off-by:Shiv Verma <shverma@redhat.com>
@PuneetPunamiya
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2021
@vinamra28
Copy link
Member

/lgtm
/meow

@tekton-robot
Copy link

@vinamra28: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PuneetPunamiya
Copy link
Member

/approve
/woof

@tekton-robot
Copy link

@PuneetPunamiya: dog image

In response to this:

/approve
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@tekton-robot tekton-robot merged commit 9455647 into tektoncd:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuneetPunamiya PuneetPunamiya PuneetPunamiya left review comments

@sm43 sm43 Awaiting requested review from sm43

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratap0007 @vinamra28 @PuneetPunamiya @tekton-robot