Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Adds --as-clustertask flag in get command #133

Merged
merged 1 commit into from
Dec 2, 2020
Merged

CLI: Adds --as-clustertask flag in get command #133

merged 1 commit into from
Dec 2, 2020

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Nov 9, 2020 •
edited
Loading

This adds as-clustertask command in get command which get the task
from catalog and prints it on console replacing kind as clusterTask.

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 9, 2020
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot
Copy link

@piyush-garg: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CLI: Adds --as-clustertask flag in get command
4f18c9d 
This adds as-clustertask command in get command which get the task
from catalog and prints it on console replacing kind as clusterTask.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 force-pushed the get-as-clustertask branch from 50178ce to 4f18c9d Compare November 25, 2020 05:42
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@PuneetPunamiya
Copy link
Member

/lgtm
/approve
/meow

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/lgtm
/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@tekton-robot tekton-robot merged commit 69d1b53 into tektoncd:master Dec 2, 2020
@sm43 sm43 deleted the get-as-clustertask branch January 4, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg left review comments

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@piyush-garg piyush-garg

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sm43 @piyush-garg @tekton-robot @PuneetPunamiya