API to get new refresh token for user #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XXL
|
/lgtm |
|
/hold |
tekton-robot
added
the
do-not-merge/hold
sm43
force-pushed
the
refresh-token-api
branch
from
c8ae249 to
bf1a008
Compare
sm43
changed the title
sm43
removed
the
do-not-merge/hold
tekton-robot
added
the
needs-rebase
sm43
force-pushed
the
refresh-token-api
branch
from
bf1a008 to
cd34518
Compare
tekton-robot
removed
the
needs-rebase
tekton-robot
added
the
needs-rebase
sm43
force-pushed
the
refresh-token-api
branch
from
cd34518 to
d69c3de
Compare
tekton-robot
removed
the
needs-rebase
sm43
force-pushed
the
refresh-token-api
branch
from
d69c3de to
577d66d
Compare
sm43
force-pushed
the
refresh-token-api
branch
2 times, most recently
from
b0b8446 to
c38c2df
Compare
|
/lgtm |
sm43
force-pushed
the
refresh-token-api
branch
from
c38c2df to
1dbb1e7
Compare
|
/lgtm |
api/pkg/service/user/user.go
Outdated
| // Refreshes the refresh token of User | ||
| func (s *service) NewRefreshToken(ctx context.Context, p *user.NewRefreshTokenPayload) (*user.NewRefreshTokenResult, error) { | ||
|
|
||
| user, err := s.User(ctx) |
There was a problem hiding this comment.
I think from line 135 to 151 we can create a common function and use this from both access token and refresh token since that part of code is duplicated
sm43
force-pushed
the
refresh-token-api
branch
from
1dbb1e7 to
7da2684
Compare
This adds an api to get new refresh token for user using existing refresh token before it expires. Existing refresh token must be passed in header as Authorization. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
sm43
force-pushed
the
refresh-token-api
branch
from
7da2684 to
8df86e8
Compare
|
/lgtm |
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds implementation for API to get a new refresh token for user. This
requires existing user refresh token to be passed to get a new access token.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.