Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Adds install command #121

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Oct 21, 2020

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2020
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 21, 2020
@sm43
Copy link
Member Author

sm43 commented Oct 21, 2020

/retest

1 similar comment
@sm43
Copy link
Member Author

sm43 commented Oct 22, 2020

/retest

@sm43 sm43 force-pushed the tkn-hub-install branch 8 times, most recently from 6eb258f to cc0434e Compare November 4, 2020 11:00
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 4, 2020
@sm43 sm43 changed the title [WIP] CLI: Adds install command CLI: Adds install command Nov 4, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2020
@sm43 sm43 changed the title CLI: Adds install command [WIP] CLI: Adds install command Nov 9, 2020
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2020
@sm43 sm43 changed the title [WIP] CLI: Adds install command CLI: Adds install command Nov 20, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2020
@sm43 sm43 force-pushed the tkn-hub-install branch 5 times, most recently from f1d5c56 to 6dcca4f Compare November 23, 2020 03:45
@sm43 sm43 force-pushed the tkn-hub-install branch 9 times, most recently from e49a68f to 16e89dd Compare November 24, 2020 06:51
@sthaha
Copy link
Member

sthaha commented Nov 24, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@sm43 sm43 force-pushed the tkn-hub-install branch 2 times, most recently from ed1b6c2 to 3571149 Compare December 2, 2020 18:11
This adds install command in tkn hub, has 2 subcommand task and
pipeline. by default latest version is installed.
'--version' flag can be used to pass a specific version.
'--from' flag can be used to pass catalog name.
If a resource is already installed with the passed name, will return
an error.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@PuneetPunamiya
Copy link
Member

/lgtm
/approve
/meow

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/lgtm
/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@tekton-robot tekton-robot merged commit 1731a59 into tektoncd:master Dec 9, 2020
@sm43 sm43 deleted the tkn-hub-install branch January 4, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants