Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Hub CI by bumping postgres to postgres 15 and node to 18.x #1156

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

PuneetPunamiya
Copy link
Member

@PuneetPunamiya PuneetPunamiya commented Oct 16, 2023

  • With the base image of ubuntu bumped in plumbing CI,
    postgres was not getting installed, hence this patch
    bumps the postgres version in Hub CI to as the new
    version of ubuntu supports postgres 15 and above

  • Also in this patch node version is bumped to 18.x

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2023
@PuneetPunamiya PuneetPunamiya force-pushed the fix-postgres-ci branch 12 times, most recently from e53ac4c to 929152f Compare October 17, 2023 05:28
@PuneetPunamiya PuneetPunamiya changed the title Fixes CI Fixes Hub CI by bumping postgres to postgres 15 Oct 17, 2023
@PuneetPunamiya PuneetPunamiya changed the title Fixes Hub CI by bumping postgres to postgres 15 Fixes Hub CI by bumping postgres to postgres 15 and node to 18.x Oct 17, 2023
With the base image of ubuntu bumped in plumbing CI,
postgres was not getting installed, hence this patch
bumps the postgres version in Hub CI to as the new
version of ubuntu supports postgres 15 and above

Also in this patch node version is bumped to 18.x

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@pratap0007
Copy link
Contributor

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pratap0007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@tekton-robot tekton-robot merged commit 7e3d069 into tektoncd:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants