fix: enable Vault JWT auth without Spire for KMS signing#1616
Open
infernus01 wants to merge 1 commit intotektoncd:mainfrom
Open
fix: enable Vault JWT auth without Spire for KMS signing#1616infernus01 wants to merge 1 commit intotektoncd:mainfrom
infernus01 wants to merge 1 commit intotektoncd:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/L
Member
Author
|
/kind bug |
When signers.kms.auth.oidc.path and signers.kms.auth.oidc.role are set in the Chains ConfigMap without Spire, the controller now reads the Kubernetes service account token from the pod filesystem and uses it for Vault JWT auth login. Previously, the OIDC token field was only populated by Spire, causing the code to fall through to VAULT_TOKEN lookup and fail with "read .vault-token file: no such file or directory". Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Setting
signers.kms.auth.oidc.pathandsigners.kms.auth.oidc.rolein the Chains ConfigMap without Spire does nothing. The OIDC path and role are parsed correctly but never used — the code falls through toVAULT_TOKEN/~/.vault-tokenand fails:error configuring kms signer with config {hashivault://supply-chain {http://vault.vault:8200/ {jwt tekton-chains} { }}}: read .vault-token file: open /home/nonroot/.vault-token: no such file or directoryNow with this PR, when OIDC path/role are configured and no Spire or static token is present, read the Kubernetes service account token from
/var/run/secrets/kubernetes.io/serviceaccount/tokenand use it for Vault JWT auth. A new config keysigners.kms.auth.oidc.token-pathallows overriding the default path.Priority order: Spire → static token → K8s SA token
fixes: #1479
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes