Sdbv rbac changes

[Shubham4026]

Summary by CodeRabbit

• New Features
  • Added support for displaying and managing the "enrollmentId" field for users across relevant sections of the application.
• Improvements
  • Enhanced SMS OTP delivery by using a configurable template key for notifications.
• Style
  • Improved code clarity and type safety in form-related operations (no user-facing changes).

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a new non-nullable string column, enrollmentId, to the User entity and update related SQL queries and data access methods to include this field. Additionally, SMS OTP sending logic now uses a configurable template key, and type annotations for Express request and response objects are added to controller methods.

Changes

File(s)	Change Summary
src/user/entities/user-entity.ts	Added non-nullable enrollmentId column to User entity definition.
src/adapters/postgres/user-adapter.ts	Included enrollmentId in user queries and DTOs; added config-based SMS template key; improved OTP replacements.
src/adapters/postgres/cohortMembers-adapter.ts	Updated SQL query to select enrollmentId in user retrieval.
src/forms/forms.controller.ts	Added explicit Request and Response type annotations from Express to controller method parameters.

Sequence Diagram(s)

sequenceDiagram
    participant Controller as FormsController
    participant Service as PostgresUserService
    participant DB as Database

    Controller->>Service: getFormData(request: Request, response: Response)
    Service->>DB: SELECT ... enrollmentId ... FROM Users WHERE ...
    DB-->>Service: User data with enrollmentId
    Service-->>Controller: Return user/form data

Loading

sequenceDiagram
    participant UserService as PostgresUserService
    participant Config as ConfigService
    participant SMS as SMSNotificationService

    UserService->>Config: Get MSG91_TEMPLATE_KEY
    UserService->>SMS: sendOTPOnMobile(mobile, reason, { "{var1}": OTP }, templateKey)
    SMS-->>UserService: SMS sent response

Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-13T06_34_39_402Z-debug-0.log

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between d84958a and 1b80d2e.

📒 Files selected for processing (4)

• src/adapters/postgres/cohortMembers-adapter.ts (1 hunks)
• src/adapters/postgres/user-adapter.ts (7 hunks)
• src/forms/forms.controller.ts (1 hunks)
• src/user/entities/user-entity.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud