Skip to content

Conversation

komalreddy3
Copy link
Contributor

As for the rules, created a new folder of algorithm Valid Parantheses which contains the js file and updated the same in readme file

@tejas-2232
Copy link
Owner

Hi Komal, Thanks for contributing. Your PR is under review. Have a good day!

@tejas-2232
Copy link
Owner

tejas-2232 commented Jan 4, 2024

As for the rules, created a new folder of algorithm Valid Parantheses which contains the js file and updated the same in readme file
@komalreddy3
Well the PR looks good, except - the spelling of parentheses in README file is not correct and please rename the folder from validParantheses_15 to 15. Valid Parentheses

Let me know if you have any questions/suggestions.

@komalreddy3
Copy link
Contributor Author

I have done the Modifications as requested , Please let me know if there is anything else to be done

@tejas-2232
Copy link
Owner

I have done the Modifications as requested , Please let me know if there is anything else to be done

Good, but I see the spelling is still incorrect.

@komalreddy3
Copy link
Contributor Author

Updated as mentioned

@tejas-2232
Copy link
Owner

Updated as mentioned

Thank you! Its ready to merge but please also check spelling of the folder you've uploaded! 😃

@tejas-2232 tejas-2232 added the VALID Pull request is valid and merged label Jan 5, 2024
@tejas-2232 tejas-2232 changed the title Added a Algorithm named Valid parantheses Added a Algorithm named Valid parentheses Jan 5, 2024
@tejas-2232 tejas-2232 merged commit c84f03c into tejas-2232:master Jan 5, 2024
@komalreddy3
Copy link
Contributor Author

Updated . There is something wrong with my spelling vocabulary 😂

@tejas-2232
Copy link
Owner

Updated . There is something wrong with my spelling vocabulary 😂

No problem 😄
I know mistakes can happen. I also do sometimes.
Always check spellings before submissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

VALID Pull request is valid and merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants