remove stray assert False in order to fix #27
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I understand the comment in the while loop correctly, the purpose of the while loop here is to throw away everything which is sent by the sender to empty the UART buffer, and wait until a timeout occurs (`if data is None`, i.e. everything is sent, end of the current packet). However, due to the `assert`, the loop terminates after the first byte, unless it timeouts (which will most probably not be the case on current connections). Fixes tehmaze#27
|
Approved for merge, I should be able to bump and release to pypi in 10 or so hours when I get home to the computer with the necessary access. |
|
Okie dokie, merged to master and published to pypi. Thanks a bunch! |
|
Yay, thanks \o/ |
rohieb
added a commit
to rohieb/labgrid
that referenced
this pull request
May 23, 2017
Fixes retransmit errors, see tehmaze/xmodem#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand the comment in the while loop correctly, the purpose of the while loop here is to throw away everything which is sent by the sender to empty the UART buffer, and wait until a timeout occurs (
if data is None, i.e. everything is sent, end of the current packet). However, due to theassert, the loop terminates after the first byte, unless it timeouts (which will most probably not be the case on current connections).Fixes #27