Skip to content

Conversation

@stealthinu
Copy link
Contributor

@stealthinu stealthinu commented May 6, 2025

.envでOPENAI_TTS_KEYを設定していますが、パラメータ名がOPENAI_KEYにtypoしていたため設定が利用されない状況になっていました。OPENAI_API_KEYが設定されていた場合はこちらが利用されていたため問題が顕在化しなかったのではないかと思います。

Summary by CodeRabbit

  • その他
    • OpenAIのテキスト読み上げ機能で利用するAPIキーの取得方法が変更されました。

@vercel
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aituber-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 9:37am

@coderabbitai
Copy link

coderabbitai bot commented May 6, 2025

Walkthrough

OpenAIのテキスト読み上げ(TTS)APIリクエストに使用するAPIキーの取得ロジックが変更されました。これまでOPENAI_KEYを優先していましたが、今後はOPENAI_TTS_KEYを優先し、次にOPENAI_API_KEYを参照します。他の処理やエラーハンドリングには変更ありません。

Changes

ファイル/パス 変更内容の概要
src/pages/api/openAITTS.ts OpenAI TTS用APIキーの取得優先順位をOPENAI_KEYからOPENAI_TTS_KEYへ変更。フォールバック先はOPENAI_API_KEYのまま。

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant APIHandler
    participant OpenAI

    Client->>APIHandler: TTSリクエスト送信
    APIHandler->>APIHandler: OPENAI_TTS_KEY取得
    alt OPENAI_TTS_KEYが存在しない場合
        APIHandler->>APIHandler: OPENAI_API_KEY取得
    end
    APIHandler->>OpenAI: APIキーでTTSリクエスト
    OpenAI-->>APIHandler: レスポンス返却
    APIHandler-->>Client: レスポンス返却
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between baf46ff and d03a564.

📒 Files selected for processing (1)
  • src/pages/api/openAITTS.ts (1 hunks)
🔇 Additional comments (1)
src/pages/api/openAITTS.ts (1)

14-14: 環境変数名の修正が適切に行われています!

OPENAI_KEYからOPENAI_TTS_KEYへの変更は、環境変数の命名をより明確にし、特定の目的(テキスト読み上げ)を反映しています。これにより、.envファイルでの設定が正しく認識されるようになります。フォールバックとしてOPENAI_API_KEYを保持しているため、後方互換性も維持されています。

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tegnike tegnike changed the base branch from main to develop May 6, 2025 09:41
@tegnike
Copy link
Owner

tegnike commented May 6, 2025

PRありがとうございます!
確かに変ですね、こちらの対応で問題ないのでマージしようと思います。

ただこちらですが、実は {サービス名}_API_KEY で統一しようという考えがありまして、そのうち以下のように変更する予定です。

  const openaiKey = apiKey || process.env.OPENAI_API_KEY

@tegnike tegnike merged commit 3fe0c73 into tegnike:develop May 6, 2025
5 checks passed
@stealthinu
Copy link
Contributor Author

stealthinu commented May 6, 2025

早速マージしていただいてありがとうございます!
確かに。あえてそこを別APIキーにする必要性はなさそうなのですものね。

@tegnike
Copy link
Owner

tegnike commented May 6, 2025

mainブランチへのマージはもう少しお待ち下さい!

terisuke pushed a commit to terisuke/aituber-kit that referenced this pull request Dec 5, 2025
OPENAI_TTS_KEYにすべきところのtypoを修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants