にじボイスの設定追加 & その他 #264
Merged
にじボイスの設定追加 & その他 #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ウォークスルーこのプルリクエストでは、2つのコンポーネントに重要な変更が加えられました。 変更点
シーケンス図sequenceDiagram
participant User
participant MessageInput
participant OnClickSendButton
User->>MessageInput: クリック/送信
MessageInput->>MessageInput: handleSendClick()
MessageInput->>OnClickSendButton: 呼び出し
MessageInput->>MessageInput: テキストエリアをリセット
sequenceDiagram
participant User
participant VoiceSettings
participant NijiVoiceSpeakers
User->>VoiceSettings: アクターを選択
VoiceSettings->>VoiceSettings: prevNijivoiceActorIdを更新
VoiceSettings->>NijiVoiceSpeakers: 選択されたアクターを取得
NijiVoiceSpeakers-->>VoiceSettings: 推奨音声速度
VoiceSettings->>VoiceSettings: nijivoiceSpeedを更新
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/components/messageInput.tsx(3 hunks)src/components/settings/voice.tsx(2 hunks)
🔇 Additional comments (4)
src/components/messageInput.tsx (3)
49-50: テキストエリアのリセット処理が適切に実装されています！
チャット処理完了後のテキストエリアの高さとrow数のリセットが適切に実装されており、UIの一貫性が保たれています。
85-91: 送信ボタンのクリックハンドラーが適切にカプセル化されています！
テキストエリアのリセット処理を含む送信ボタンのロジックが、新しいhandleSendClick関数に適切にカプセル化されています。
143-143: 送信ボタンのonClickハンドラーが正しく更新されています！
新しいhandleSendClick関数が送信ボタンのonClickハンドラーとして適切に設定されています。
src/components/settings/voice.tsx (1)
66-66: 前回選択された話者IDの状態管理が適切に実装されています！
prevNijivoiceActorIdの状態変数を使用して、話者の変更を追跡する実装が適切です。
Comment on lines
+93
to
+115
| // nijivoiceActorIdが変更された時にrecommendedVoiceSpeedを設定する処理を追加 | ||
| useEffect(() => { | ||
| if ( | ||
| selectVoice === 'nijivoice' && | ||
| nijivoiceActorId && | ||
| nijivoiceActorId !== prevNijivoiceActorId | ||
| ) { | ||
| // 現在選択されているキャラクターを探す | ||
| const selectedActor = nijivoiceSpeakers.find( | ||
| (actor) => actor.id === nijivoiceActorId | ||
| ) | ||
|
|
||
| // キャラクターが見つかり、recommendedVoiceSpeedが設定されている場合 | ||
| if (selectedActor?.recommendedVoiceSpeed) { | ||
| settingsStore.setState({ | ||
| nijivoiceSpeed: selectedActor.recommendedVoiceSpeed, | ||
| }) | ||
| } | ||
|
|
||
| // 前回の選択を更新 | ||
| setPrevNijivoiceActorId(nijivoiceActorId) | ||
| } | ||
| }, [nijivoiceActorId, nijivoiceSpeakers, prevNijivoiceActorId, selectVoice]) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
話者変更時の音声速度自動調整機能について、エラーハンドリングの追加を推奨します。
話者変更時のrecommendedVoiceSpeedの設定は適切ですが、以下の改善を提案します：
selectedActorが見つからない場合のエラーハンドリング- 無効な
recommendedVoiceSpeed値のバリデーション
以下の実装を提案します：
useEffect(() => {
if (
selectVoice === 'nijivoice' &&
nijivoiceActorId &&
nijivoiceActorId !== prevNijivoiceActorId
) {
// 現在選択されているキャラクターを探す
const selectedActor = nijivoiceSpeakers.find(
(actor) => actor.id === nijivoiceActorId
)
+ // キャラクターが見つからない場合のエラーハンドリング
+ if (!selectedActor) {
+ console.warn(`選択された話者ID ${nijivoiceActorId} が見つかりません。`)
+ return
+ }
// キャラクターが見つかり、recommendedVoiceSpeedが設定されている場合
- if (selectedActor?.recommendedVoiceSpeed) {
+ if (selectedActor.recommendedVoiceSpeed) {
+ // 推奨速度が有効な範囲内かチェック
+ const speed = Number(selectedActor.recommendedVoiceSpeed)
+ if (isNaN(speed) || speed < 0.4 || speed > 3.0) {
+ console.warn(`無効な推奨速度です: ${speed}`)
+ return
+ }
settingsStore.setState({
- nijivoiceSpeed: selectedActor.recommendedVoiceSpeed,
+ nijivoiceSpeed: speed,
})
}
// 前回の選択を更新
setPrevNijivoiceActorId(nijivoiceActorId)
}
}, [nijivoiceActorId, nijivoiceSpeakers, prevNijivoiceActorId, selectVoice])📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // nijivoiceActorIdが変更された時にrecommendedVoiceSpeedを設定する処理を追加 | |
| useEffect(() => { | |
| if ( | |
| selectVoice === 'nijivoice' && | |
| nijivoiceActorId && | |
| nijivoiceActorId !== prevNijivoiceActorId | |
| ) { | |
| // 現在選択されているキャラクターを探す | |
| const selectedActor = nijivoiceSpeakers.find( | |
| (actor) => actor.id === nijivoiceActorId | |
| ) | |
| // キャラクターが見つかり、recommendedVoiceSpeedが設定されている場合 | |
| if (selectedActor?.recommendedVoiceSpeed) { | |
| settingsStore.setState({ | |
| nijivoiceSpeed: selectedActor.recommendedVoiceSpeed, | |
| }) | |
| } | |
| // 前回の選択を更新 | |
| setPrevNijivoiceActorId(nijivoiceActorId) | |
| } | |
| }, [nijivoiceActorId, nijivoiceSpeakers, prevNijivoiceActorId, selectVoice]) | |
| // nijivoiceActorIdが変更された時にrecommendedVoiceSpeedを設定する処理を追加 | |
| useEffect(() => { | |
| if ( | |
| selectVoice === 'nijivoice' && | |
| nijivoiceActorId && | |
| nijivoiceActorId !== prevNijivoiceActorId | |
| ) { | |
| // 現在選択されているキャラクターを探す | |
| const selectedActor = nijivoiceSpeakers.find( | |
| (actor) => actor.id === nijivoiceActorId | |
| ) | |
| // キャラクターが見つからない場合のエラーハンドリング | |
| if (!selectedActor) { | |
| console.warn(`選択された話者ID ${nijivoiceActorId} が見つかりません。`) | |
| return | |
| } | |
| // キャラクターが見つかり、recommendedVoiceSpeedが設定されている場合 | |
| if (selectedActor.recommendedVoiceSpeed) { | |
| // 推奨速度が有効な範囲内かチェック | |
| const speed = Number(selectedActor.recommendedVoiceSpeed) | |
| if (isNaN(speed) || speed < 0.4 || speed > 3.0) { | |
| console.warn(`無効な推奨速度です: ${speed}`) | |
| return | |
| } | |
| settingsStore.setState({ | |
| nijivoiceSpeed: speed, | |
| }) | |
| } | |
| // 前回の選択を更新 | |
| setPrevNijivoiceActorId(nijivoiceActorId) | |
| } | |
| }, [nijivoiceActorId, nijivoiceSpeakers, prevNijivoiceActorId, selectVoice]) |
This was referenced Dec 16, 2024
Merged
Merged
Merged
terisuke
pushed a commit
to terisuke/aituber-kit
that referenced
this pull request
Dec 5, 2025
にじボイスの設定追加 & その他
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
新機能
バグ修正