文中にある感情タグを読み上げてしまう不具合修正 #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthroughこのプルリクエストでは、 Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
src/features/chat/handlers.ts (1)
70-70: 正規表現の修正が適切に実装されています感情タグを文章の区切りとして認識する
(?=\[)の追加により、タグが読み上げられてしまう問題が解決されています。将来的な保守性を考慮して、以下の改善を提案します：
-/^(.{1,19}?(?:[。．.!?！？\n]|(?=\[))|.{20,}?(?:[、,。．.!?！？\n]|(?=\[)))/ +const SENTENCE_BOUNDARY = /^(.{1,19}?(?:[。．.!?！？\n]|(?=\[))|.{20,}?(?:[、,。．.!?！？\n]|(?=\[)))/;この定数を共通で使用することで、両関数での一貫性が保証され、将来の修正も容易になります。
Also applies to: 219-219
src/features/chat/handlers.ts
Outdated
| /^(.{1,19}?[。．.!?！？\n]|.{20,}?[、,。．.!?！？\n])/ | ||
| /^(.{1,19}?(?:[。．.!?！？\n]|(?=\[))|.{20,}?(?:[、,。．.!?！？\n]|(?=\[)))/ | ||
| ) | ||
| console.log('sentenceMatch', sentenceMatch) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
デバッグログの取り扱いについて
開発時のデバッグに有用なログですが、以下の点について検討が必要です：
- 本番環境での不要なログ出力
- ユーザーの会話内容が含まれる可能性があるプライバシーの懸念
以下のような改善を提案します：
-console.log('sentenceMatch', sentenceMatch)
+if (process.env.NODE_ENV === 'development') {
+ console.debug('sentenceMatch:', sentenceMatch)
+}-console.log('sentence', sentence)
+if (process.env.NODE_ENV === 'development') {
+ console.debug('sentence:', sentence)
+}Also applies to: 101-101
Merged
Merged
This was referenced Mar 23, 2025
Merged
terisuke
pushed a commit
to terisuke/aituber-kit
that referenced
this pull request
Dec 5, 2025
文中にある感情タグを読み上げてしまう不具合修正
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連
Summary by CodeRabbit
Summary by CodeRabbit
新機能
バグ修正