-
-
Notifications
You must be signed in to change notification settings - Fork 143
本番リリース #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
本番リリース #231
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d672411
feat(i18n): 台湾繁体字(zh)のロケールファイルを更新
yelban 6da0fd6
何度もWebSocket接続してしまう不具合修正
tegnike f8ee518
コミット忘れ
tegnike a06411d
ドキュメント更新
tegnike 7605f8b
新しいOpenAIのモデル追加
tegnike d0e14e2
AivisSpeechに話者リスト更新ボタン追加
tegnike 526f39d
Merge pull request #230 from tegnike/feature/fix-websocket-bug
tegnike 25d22e5
Merge pull request #220 from yelban/zh
tegnike 7df8622
Merge pull request #229 from tegnike/feature/update-documents2
tegnike 228e81a
Merge pull request #227 from tegnike/feature/add-new-openai-model
tegnike 6e787af
Merge pull request #228 from tegnike/feature/add-update-button-for-aivis
tegnike b1970d8
バージョン更新
tegnike 0e97a9d
モデル名が誤っていたので修正
tegnike File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -439,7 +439,7 @@ const Voice = () => { | |
| label="https://aivis-project.com/" | ||
| /> | ||
| </div> | ||
| <div className="mt-16 font-bold">{t('SpeakerSelection')}</div> | ||
| <div className="mt-16 font-bold">{t('AivisSpeechSpeaker')}</div> | ||
| <div className="flex items-center"> | ||
| <select | ||
| value={aivisSpeechSpeaker} | ||
|
|
@@ -463,6 +463,28 @@ const Voice = () => { | |
| > | ||
| {t('TestVoice')} | ||
| </TextButton> | ||
| <TextButton | ||
| onClick={async () => { | ||
| const response = await fetch('/api/update-aivis-speakers') | ||
| if (response.ok) { | ||
| // 話者リストを再読み込み | ||
| const updatedSpeakersResponse = await fetch( | ||
| '/speakers_aivis.json' | ||
| ) | ||
| const updatedSpeakers = | ||
| await updatedSpeakersResponse.json() | ||
| // speakers_aivisを更新 | ||
| speakers_aivis.splice( | ||
| 0, | ||
| speakers_aivis.length, | ||
| ...updatedSpeakers | ||
| ) | ||
| } | ||
| }} | ||
| className="ml-16" | ||
| > | ||
| {t('UpdateSpeakerList')} | ||
| </TextButton> | ||
|
Comment on lines
+466
to
+487
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 話者リストの更新機能に改善の余地があります 以下の点について改善を提案します:
以下のような実装を推奨します: <TextButton
onClick={async () => {
+ try {
+ settingsStore.setState({ isUpdatingSpeakers: true });
const response = await fetch('/api/update-aivis-speakers')
- if (response.ok) {
- // 話者リストを再読み込み
- const updatedSpeakersResponse = await fetch(
- '/speakers_aivis.json'
- )
- const updatedSpeakers =
- await updatedSpeakersResponse.json()
- // speakers_aivisを更新
- speakers_aivis.splice(
- 0,
- speakers_aivis.length,
- ...updatedSpeakers
- )
+ if (!response.ok) {
+ throw new Error('更新に失敗しました');
}
+ const updatedSpeakersResponse = await fetch('/speakers_aivis.json');
+ const updatedSpeakers = await updatedSpeakersResponse.json();
+ settingsStore.setState({ speakers_aivis: updatedSpeakers });
+ alert('話者リストを更新しました');
+ } catch (error) {
+ console.error('話者リスト更新エラー:', error);
+ alert('話者リストの更新に失敗しました');
+ } finally {
+ settingsStore.setState({ isUpdatingSpeakers: false });
+ }
}}
className="ml-16"
+ disabled={settingsStore((s) => s.isUpdatingSpeakers)}
>
- {t('UpdateSpeakerList')}
+ {settingsStore((s) => s.isUpdatingSpeakers)
+ ? t('Updating')
+ : t('UpdateSpeakerList')
+ }
</TextButton>
|
||
| </div> | ||
| <div className="my-24 font-bold"> | ||
| <div className="select-none"> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,26 @@ | ||
| [ | ||
| { "speaker": "Anneli/ノーマル", "id": 888753760 }, | ||
| { "speaker": "Anneli/通常", "id": 888753761 }, | ||
| { "speaker": "Anneli/テンション高め", "id": 888753762 }, | ||
| { "speaker": "Anneli/落ち着き", "id": 888753763 }, | ||
| { "speaker": "Anneli/上機嫌", "id": 888753764 }, | ||
| { "speaker": "Anneli/怒り・悲しみ", "id": 888753765 } | ||
| { | ||
| "speaker": "Anneli/ノーマル", | ||
| "id": 888753760 | ||
| }, | ||
| { | ||
| "speaker": "Anneli/通常", | ||
| "id": 888753761 | ||
| }, | ||
| { | ||
| "speaker": "Anneli/テンション高め", | ||
| "id": 888753762 | ||
| }, | ||
| { | ||
| "speaker": "Anneli/落ち着き", | ||
| "id": 888753763 | ||
| }, | ||
| { | ||
| "speaker": "Anneli/上機嫌", | ||
| "id": 888753764 | ||
| }, | ||
| { | ||
| "speaker": "Anneli/怒り・悲しみ", | ||
| "id": 888753765 | ||
| } | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
画像のアクセシビリティを改善してください
スクリーンリーダーのユーザーのために、画像にalt属性を追加することを推奨します。
以下の修正を適用してください:
📝 Committable suggestion
🧰 Tools
🪛 Markdownlint
3-3: null
Images should have alternate text (alt text)
(MD045, no-alt-text)