Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter element unions against fixed attribute values #1066

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Conversation

tefra
Copy link
Owner

@tefra tefra commented Jul 28, 2024

📒 Description

For union fields, the parser has to attempt parsing with each type and then decide which output is the "most" successful. This is is slow and painful process, this pr adds an optimization strategy when union types have fixed attributes.

Resolves #1057

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cce0a16) to head (1f05835).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1066   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         9238      9259   +21     
  Branches      2179      2183    +4     
=========================================
+ Hits          9238      9259   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit 6eccffb into main Jul 28, 2024
14 checks passed
@tefra tefra deleted the union-perf branch July 28, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML parsing approximately 200 times slower than parsing to in-built xml.etree.ElementTree.Element
1 participant