Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset attr types derived from empty simple types #1062

Merged
merged 2 commits into from
Jun 29, 2024
Merged

fix: Reset attr types derived from empty simple types #1062

merged 2 commits into from
Jun 29, 2024

Conversation

tefra
Copy link
Owner

@tefra tefra commented Jun 29, 2024

📒 Description

When we process attribute types derived from simple types, that are incomplete due to a missing xsd, we should reset the type and log a warning like we do for all absent xs types.

Resolves #1059

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

@tefra tefra changed the title Reset attr types derived from empty simple types fix: Reset attr types derived from empty simple types Jun 29, 2024
Copy link

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3ad50f2) to head (6135e9a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1062   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         9234      9238    +4     
  Branches      2178      2179    +1     
=========================================
+ Hits          9234      9238    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit cce0a16 into main Jun 29, 2024
15 checks passed
@tefra tefra deleted the fix-1059 branch June 29, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generation raises and index out of range when not all includes are provided
1 participant