-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an extra escape wrapper for illegal XML chars in junit report plugin #3289
Conversation
a7a6525
to
539e109
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Looks good and works as expected.
Thanks for the review @psss ! Have you also tested the changes against the internal "base-os" tmt tests? Thanks. |
/packit test |
Yes, before the change there's the traceback, with the change everything's green. |
1f0b082
to
f6ecb85
Compare
/packit test |
The default Jinja
escape
(e
) filter does not escape the XML illegal characters (like control characters). The python-xml-junit library was replacing the characters with an empty string:For more info, please see:
Pull Request Checklist