Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message provided when plugin IDs collide #3288

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Improve message provided when plugin IDs collide #3288

merged 1 commit into from
Oct 16, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Oct 15, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature

@happz happz added this to the 1.38 milestone Oct 15, 2024
@happz happz marked this pull request as ready for review October 15, 2024 08:11
@happz happz added ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Oct 15, 2024
@happz
Copy link
Collaborator Author

happz commented Oct 15, 2024

/packit test

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Oct 15, 2024
@psss psss force-pushed the improve-plugin-registry-collision-message branch from 31f0da8 to 0d0187d Compare October 16, 2024 06:34
@psss psss force-pushed the improve-plugin-registry-collision-message branch from 0d0187d to 6433803 Compare October 16, 2024 06:44
@psss
Copy link
Collaborator

psss commented Oct 16, 2024

Just irrelevant failures Failed to download metadata for repo 'baseos-debuginfo' failures, merging.

@psss psss merged commit e5db5e6 into main Oct 16, 2024
16 of 22 checks passed
@psss psss deleted the improve-plugin-registry-collision-message branch October 16, 2024 12:18
@psss psss self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@psss psss psss approved these changes

@janhavlin janhavlin janhavlin approved these changes

@therazix therazix therazix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.38
Development

Successfully merging this pull request may close these issues.
5 participants
@happz @psss @KwisatzHaderach @janhavlin @therazix