Add a lint check for empty and missing environment files

[mcasquer]

New function that raises a failure if the size of
the environment file, if this one exists, is zero.

Pull Request Checklist

• implement the feature
• extend the test coverage
• include a release note

[psss]

Thanks for improving this! Added a couple comments. Would be good to handle the non-existent file as part of the lint report instead of bailing out with a catched exception.

Would you mind adding a simple test coverage? You could just extend the existing test. Also, what about adding a short release note?

[psss]

Would you mind adding a simple test coverage? You could just extend the existing test. Also, what about adding a short release note?

@mcasquer, what do you think about adding a simple test and a short release note?

[mcasquer]

Would you mind adding a simple test coverage? You could just extend the existing test. Also, what about adding a short release note?

@mcasquer, what do you think about adding a simple test and a short release note?

Perfect, I will add them along with the above suggestions !

[psss]

Now looks good, thanks! Added just a few minor adjustments in 2ec0304.

[psss]

/packit test

[psss]

/packit build

[psss]

Test /tests/lint/plan/explicit-root is failing. Seems that your newly added test coverage has revealing a bug. Congratulations! :) Here are simple steps to reproduce:

> cd tests/lint/plan/data
> tmt plan lint good
/good
pass C000 fmf node passes schema validation
pass C001 summary key is set and is reasonably long
pass P001 correct keys are used
pass P002 execute step defined with "how"
pass P003 execute step methods are all known
skip P004 discover step is not defined
skip P005 no remote fmf ids defined
pass P006 phases have unique names
pass P007 execute phase 'default-0' does not require specific guest
pass P008 no empty environment files

Lint checks on all
pass G001 no duplicate ids detected

> cd ..
> tmt --root data plan lint good

[Errno 2] No such file or directory: '/home/psss/git/tmt/tests/lint/plan/env'

Both commands should give the same result as the --root option is instructing tmt to use provided directory as the fmf metadata tree root. Seems that path to the env file is not correctly constructed when --root is used. @mcasquer, could you please have a look?

[mcasquer]

Both commands should give the same result as the --root option is instructing tmt to use provided directory as the fmf metadata tree root. Seems that path to the env file is not correctly constructed when --root is used. @mcasquer, could you please have a look?

@psss Ok I will take a look :)