Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre commit bump #3197

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Pre commit bump #3197

merged 2 commits into from
Sep 11, 2024

Conversation

martinhoyer
Copy link
Collaborator

Another monthly version bump which could be automated, but not really because there are too many failures but we're getting there.

@martinhoyer martinhoyer added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. pre-commit labels Sep 6, 2024
@martinhoyer martinhoyer added this to the 1.37 milestone Sep 6, 2024
@martinhoyer martinhoyer self-assigned this Sep 6, 2024
@martinhoyer
Copy link
Collaborator Author

@happz this is me commiting e6ecfc1

, so if you can take a look, it would be much appreciated.

@martinhoyer martinhoyer added the ci | full test Pull request is ready for the full test execution label Sep 6, 2024
happz
happz reviewed Sep 6, 2024
View reviewed changes
tmt/utils/__init__.py Outdated Show resolved Hide resolved
@happz happz added test coverage Improvements or additions to test coverage of tmt itself and removed pre-commit labels Sep 6, 2024
@happz
Copy link
Collaborator

happz commented Sep 6, 2024

LGTM. BTW dropping pre-commit label, IIUIC, it's rather "tmt in pre-commit" than "pre-commit in tmt".

@martinhoyer
Copy link
Collaborator Author

LGTM. BTW dropping pre-commit label, IIUIC, it's rather "tmt in pre-commit" than "pre-commit in tmt".

Hmm, make sense. Thanks!

@martinhoyer martinhoyer force-pushed the pre-commit_bump branch 2 times, most recently from 2923eee to e4fab2f Compare September 7, 2024 10:54
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Sep 10, 2024
martinhoyer and others added 2 commits September 11, 2024 09:34
@martinhoyer @happz
Update pre-commit hooks and fix new ruff errors
3c469b9 
Ruff rules addressed: ICN001, PT001, PT023, PLR1730.
@martinhoyer @happz
Address mypy, pyright errors
d82d2f2 
Co-authored-by: Miloš Prchlík <happz@happz.cz>
@happz
Copy link
Collaborator

happz commented Sep 11, 2024

Unrelated failure, merging.

@happz happz merged commit 5370e0a into teemtee:main Sep 11, 2024
20 of 21 checks passed
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@martinhoyer @The-Mule
Pre commit bump (teemtee#3197)
c692e6c 
Ruff rules addressed: ICN001, PT001, PT023, PLR1730.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@seberm seberm seberm approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@janhavlin janhavlin janhavlin approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

Assignees

@martinhoyer martinhoyer

Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
5 participants
@martinhoyer @happz @seberm @KwisatzHaderach @janhavlin