-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the link
command and linking new tests to jira
#2922
Conversation
link
command and linking to jira on new issues
Could use an example of how this works. Probably this needs to be abstracted a bit for more arbitrary issue providers. Are there no plans yet to strip out some of the tmt plugins in order to minimize the dependencies and tests? |
This is currently WIP, hence why it is in Draft. Will provide more information once the initial refactor suggested by @psss in a discussion will be implemented. |
Added a section to documentation which should explain what this change aims to introduce. Related Jira issue TT-262. |
Thanks for the clarification I kinda understand the setup, and I am more confused about it at the same time. The main idea is to add in the Another question I have is what happens with the links when a test/structure gets refactored. Could the tests be traced back through the git tree to see how it evolves and re-links? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this! Overall looks very good. Added some comments and suggestions.
This is an important feature blocking proper Jira integration and traceability. Marking as a |
@tkoscieln, could you please address the comments and add a short release note? Thanks! |
e8bd09c
to
4db974c
Compare
Traceback (most recent call last): File "/home/psss/.local/share/hatch/env/virtual/tmt/v_yBwOy-/dev/bin/tmt", line 5, in <module> from tmt.__main__ import run_cli File "/home/psss/git/tmt/tmt/__init__.py", line 20, in <module> from tmt.base import Clean, Plan, Run, Status, Story, Test, Tree File "/home/psss/git/tmt/tmt/base.py", line 57, in <module> import tmt.utils.jira File "/home/psss/git/tmt/tmt/utils/jira.py", line 21, in <module> tmt.log.Logger.get_bootstrap_logger()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/psss/git/tmt/tmt/log.py", line 871, in get_bootstrap_logger cls._bootstrap_logger = Logger.create(actual_logger=actual_logger) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/psss/git/tmt/tmt/log.py", line 686, in create return Logger( ^^^^^^^ File "/home/psss/git/tmt/tmt/log.py", line 629, in apply_verbosity_options debug_level_from_global_envvar = _debug_level_from_global_envvar() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/psss/git/tmt/tmt/log.py", line 123, in _debug_level_from_global_envvar raise tmt.utils.GeneralError(f"Invalid debug level '{raw_value}', use an integer.") tmt.utils.GeneralError: Invalid debug level 'weird', use an integer.
This reverts commit 0c630b7.
Move under `Elasticity` Simplify some wording. Use the planned `tmt-web-url`.
Extra line Duplicate requires Missing docstrings Consistent option name
Introduce the `JiraInstance` class Separate code into more functions/methods. Simplify object detection in `cli.py`, handle empty case.
e6dbb87
to
7ecd3bb
Compare
I believe all crucial comments should be covered. I suggest to include this new functionality as a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After changes in 7ecd3bb should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
One last thought - should jira.py
be under tmt/utils/
? Doesn't feel right to me. Non-blocking of course, can be moved later if desired.
The
Does not seem to be related. Rerunning though. |
Ack, yeah, we can find a better place for it in the future. |
Failures seem to be related to |
link
command and linking to jira on new issueslink
command and linking new tests to jira
Co-authored-by: Martin Hoyer <mhoyer@redhat.com> Co-authored-by: Petr Šplíchal <psplicha@redhat.com> Co-authored-by: Miloš Prchlík <mprchlik@redhat.com>
Pull Request Checklist