-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid leaking non-key members into keys()/items()/to_dict()/... output #1688
Comments
Good point. As those internal keys are not part of the specification we could possibly just ignore them? At least during the export. |
Not a good idea in the long run, as some names not worthy of exporting can easily not start with an underscore, but I agree it's the best we can do to patch it for 1.20/quickly. The proper solution would land later. |
Ack. |
Understood, ok. |
Fields starting with underscore, `_`, are considered "private" and should not be exported. This is a "dirty" workaround to fix #1729, a proper fix would probably turn the table around, and instead of hiding some fields it would export only fields marked for export. That should be implemented later for #1688. Fixes #1729.
Fields starting with underscore, `_`, are considered "private" and should not be exported. This is a "dirty" workaround to fix #1729, a proper fix would probably turn the table around, and instead of hiding some fields it would export only fields marked for export. That should be implemented later for #1688. Fixes #1729.
Note the keys beginning with underscore,
_imported_plan
,_reboot_count
, and so on - these do not have any place to be in the output ofkeys()
and & co, as they are not keys recognized by tmt specification, but implementation details. We need a way to avoid exposing them.The text was updated successfully, but these errors were encountered: