Skip to content
This repository has been archived by the owner on Oct 16, 2022. It is now read-only.

Timeshift skips some hourly backup. #497

Closed
Xwang1976 opened this issue Oct 17, 2019 · 0 comments
Closed

Timeshift skips some hourly backup. #497

Xwang1976 opened this issue Oct 17, 2019 · 0 comments

Comments

@Xwang1976
Copy link

Note: This application is provided "as-is" without support or warranty. If you need help with issues, consider making a donation to support the development.

Describe the bug
Timeshift skips some hourly backup.
I've set to keep 24 backups, but timeshift skips some backups as you can see from this list of hourly snapshots:

[andreak@n752vx snapshots-hourly]$ ls -all
totale 8
drwxr-xr-x 2 root root 4096 17 ott 15.03 .
drwxr-xr-x 9 root root 4096 17 ott 15.03 ..
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_06-00-01 -> ../snapshots/2019-10-16_06-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_07-00-01 -> ../snapshots/2019-10-16_07-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_08-00-01 -> ../snapshots/2019-10-16_08-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_10-00-01 -> ../snapshots/2019-10-16_10-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_11-00-04 -> ../snapshots/2019-10-16_11-00-04
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_13-00-01 -> ../snapshots/2019-10-16_13-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_14-00-01 -> ../snapshots/2019-10-16_14-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_15-00-04 -> ../snapshots/2019-10-16_15-00-04
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_17-00-01 -> ../snapshots/2019-10-16_17-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_18-00-01 -> ../snapshots/2019-10-16_18-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_19-00-01 -> ../snapshots/2019-10-16_19-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_20-00-04 -> ../snapshots/2019-10-16_20-00-04
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_22-00-02 -> ../snapshots/2019-10-16_22-00-02
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-16_23-00-03 -> ../snapshots/2019-10-16_23-00-03
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-17_01-00-02 -> ../snapshots/2019-10-17_01-00-02
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-17_03-00-01 -> ../snapshots/2019-10-17_03-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-17_04-00-02 -> ../snapshots/2019-10-17_04-00-02
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-17_06-00-01 -> ../snapshots/2019-10-17_06-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-17_07-00-02 -> ../snapshots/2019-10-17_07-00-02
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-17_09-00-03 -> ../snapshots/2019-10-17_09-00-03
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-17_11-00-01 -> ../snapshots/2019-10-17_11-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-17_12-00-01 -> ../snapshots/2019-10-17_12-00-01
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-17_13-00-02 -> ../snapshots/2019-10-17_13-00-02
lrwxrwxrwx 1 root root 32 17 ott 15.03 2019-10-17_15-00-01 -> ../snapshots/2019-10-17_15-00-01

It seems to skips a snapshot if the previous one has required more than one second.

Expected behavior
I expect that every hour a snapshot is made

System:

  • Linux Distribution Name and Version: Archlinux 64bit
  • Desktop [e.g. MATE, XFCE] KDE
  • Application Version [e.g. v18.8] 19.08.1-2
rodwgs added a commit to rodwgs/timeshift that referenced this issue Apr 14, 2020
The code should be changed so that choosing a snapshot to tag follows timing similar to determining if a snapshot for a tag is needed. That is, allow for the possibility that not all runs of cron start right on the same second. A safe change to do this would be to change the timestamp comparison to account for extra seconds.
teejee2008 added a commit that referenced this issue Nov 16, 2020
Fix missing hourly backups; issues #497 and #467
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants