Add bigint support #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also extends the existing test for nullable variable width integers
… (nullable and non-nullable).
Collaborator
|
Thanks for this Ciaran. I've reworked the code a little, but it's still functionally very similar. The unit tests were very helpful. I've moved them in to their own file, so that the bigint code can be tested independently of row token parsing. I've also added integration tests for bigint. |
Contributor
Author
|
Haha, yeah I see the re-work you've done. That awful while loop stuff was caused by js2coffee, which I used to port my original commit (Javascript) into Coffeescript :) I did mean to go back over that code and swap out the while loops for decrementing for-loops as it was in the original javascript code. |
MichaelSun90
pushed a commit
to MichaelSun90/tedious
that referenced
this pull request
Dec 3, 2019
Always encrypted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiyah,
Amusingly my first attempt to use tedious failed at the first hurdle as your (known) issue around numbers greater than 2^53 not being supported (my tables use bigints as their primary keys.)
This pull request contains a very (VERY) rough implementation that returns these values as strings, I'm sure the implementation could be re-written by someone competent, but the tests should still be useful to you :)