Use a different driver in the msnodesqlv8 when on linux/mac #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensby
requested changes
Oct 12, 2021
Collaborator
dhensby
left a comment
dhensby
left a comment
There was a problem hiding this comment.
A small stylistic change.
But is this the best way to proceed instead of something like allowing users to specify the driver via the config?
This was referenced Jan 30, 2022
1 task
This was referenced Jan 30, 2022
This was referenced Jan 31, 2022
1 task
This was referenced Jan 31, 2022
This was referenced Jan 10, 2023
This was referenced Mar 21, 2023
This was referenced Sep 6, 2023
1 task
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does:
Uses a different driver in the connection string when on macos/linux than on windows so that it's possible to use the library on those systems with msnodesqlv8.
This should fix the issue #1290