Skip to content

Bulk datatype error not caught #1261

@danjsouther

Description

@danjsouther
const sql = require('mssql');

( async () => {
	const pool = new sql.ConnectionPool(sqlConfig)
	await pool.connect()

	const table = new sql.Table('Sandbox.dbo.BulkTest')
	table.create = true
	table.columns.add('ABigInt', sql.BigInt);
	table.rows.add(1.2)

	const transaction = new sql.Transaction(pool);
	await transaction.begin();

	try {
		const request = new sql.Request(transaction)
		await request.bulk(table)
		await transaction.commit();
	} catch (error) {
		console.error(error)
		await transaction.rollback();
	}
})();

Expected behaviour:

The RangeError should be caught.

Actual behaviour:

Uncaught exception

RangeError: The number 1.2 cannot be converted to BigInt because it is not an integer
    at Function.BigInt (/home/ds/bulk_test/node_modules/jsbi/dist/jsbi-cjs.js:1:352)
    at WritableTrackingBuffer.writeInt64LE (/home/ds/bulk_test/node_modules/tedious/lib/tracking-buffer/writable-tracking-buffer.js:144:40)
    at Object.generateParameterData (/home/ds/bulk_test/node_modules/tedious/lib/data-types/bigint.js:42:12)
    at generateParameterData.next (<anonymous>)
    at RowTransform._transform (/home/ds/bulk_test/node_modules/tedious/lib/bulk-load.js:131:18)
    at RowTransform.Transform._read (/home/ds/bulk_test/node_modules/readable-stream/lib/_stream_transform.js:177:10)
    at RowTransform.Transform._write (/home/ds/bulk_test/node_modules/readable-stream/lib/_stream_transform.js:164:83)
    at doWrite (/home/ds/bulk_test/node_modules/readable-stream/lib/_stream_writable.js:409:139)
    at writeOrBuffer (/home/ds/bulk_test/node_modules/readable-stream/lib/_stream_writable.js:398:5)
    at RowTransform.Writable.write (/home/ds/bulk_test/node_modules/readable-stream/lib/_stream_writable.js:307:11)

Software versions

  • NodeJS: v16.4.0
  • node-mssql: 7.1.3
  • SQL Server: 14.0.2027.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions