-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle rework #1121
Bundle rework #1121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some things I noticed at firts glance.
Thanks for all this work! As I remarked in the |
(for future cache rewrite)
Alright, that should be it. The new cache is multi-process-safe via renames, tests pass, and clippy errors have been fixed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
- Coverage 46.40% 46.11% -0.30%
==========================================
Files 176 179 +3
Lines 65118 65413 +295
==========================================
- Hits 30221 30168 -53
- Misses 34897 35245 +348 ☔ View full report in Codecov by Sentry. |
CC @CraftSpider here too. |
Hmmm |
Hmm, I'm not sure why this error would only be showing up in the cross-tests. The one thing that I can think of is that those run through the |
Just fixed #74. File names with spaces are now safe in ttbv1 bundles---but newlines will still cause errors. I'm not sure that's a problem, though, since I've never seen a legitimate use case for files with newlines. |
Here's an idea: should this new bundle format also include latex format files? Now that the bundle-building code is in Rust, it shouldn't be too hard to generate format files while we build the bundle. (assuming format files are identical on all machines) Would be nice to do that here, so that we only have one round of big, possibly disruptive changes. |
Our current bundle scheme is causing quite a few bugs. This PR (paired with tectonic-typesetting/tectonic-texlive-bundles#14) resolves many of these by implementing proper search paths in bundles.
These changes are not be breaking. Old zip and bundles will work with this PR.
(I have, however, removed the scripts that create them. They should eventually be deprecated.)
Changes in this PR:
--web-bundle
has been removed, and--bundle
now handles both URLs and paths)Most changes in this PR are in the
bundles
crate. Changes in other files are usually minor side-effects thanks to a slightly different API.