Eliminate the need for nbsp's in .md files #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Margin can be added to h1's instead of using nbsp's, but the title of the page is also in an h1 and doesn't need such space. A hacky solution is to modify the layout to include the title in an h1 with a new class, and add a css rule for that class to remove the extra space. Then the space can be added to all other h1's. This means that the title heading and nbsp's can be removed from the markdown files. This does slightly break the title of the web page. Before the page titles were <page title> --- The Tectonic Project, but now they are just <page title>. Fixing this is the next step.
Margin & padding are 0.8em instead of 2em, because ems are bigger because the font is bigger. The spacing comes out to the same size.
|
Nice, thanks! The Installation page might be a bit of a special case so maybe we will end up not wanting this CSS behavior to be the general case, but we can always change things later if it becomes an issue. |
|
Yeah, I think just reverting the first commit will restore the h1 spacing. Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a space to h1's to take the place of the nbsp's. This would normally affect the title, which is also in an h1, but the title is now derived from the title in the YAML header of the .md file and is in the header of the page instead of the body. The title of the web page (in the head) is now "<page title> --- The Tectonic Typesetting System" if page title is defined, or just "The Tectonic Typesetting System" otherwise. That is the only change to the look of the site, the layout is completely unchanged (though I only tested it in firefox).