Change email addresses to placeholders #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehzhang
reviewed
Aug 10, 2017
There was a problem hiding this comment.
Thanks for tackling this :)
There are also a few more instances if you could take a look at those, particularly in the email templates:
@jlin816 perhaps we should also have a separate ticket that renders the email values from an env variable?
.env.config
Outdated
| ADMIN_PASS='party' | ||
|
|
||
| # Used to send verification, registration, and confirmation emails | ||
| EMAIL_CONTACT='HackMIT Team <hackmit.reg.system@gmail.com>' | ||
| EMAIL_CONTACT='HackMIT Team <team@example.com>' |
There was a problem hiding this comment.
Maybe change this to also remove "HackMIT" and replace it with something like "Hackathon Team"?
app.json
Outdated
| }, | ||
| "ADMIN_PASS": "party", | ||
| "EMAIL_CONTACT": { | ||
| "description": "Used to send verification, registration, and confirmation emails", | ||
| "value": "HackMIT Team <hackmit.reg.system@gmail.com>" | ||
| "value": "HackMIT Team <team@example.com>" |
|
@ehzhang updated! |
|
Awesome, thanks @at0dd! 😄 |
krubenok
pushed a commit
to hackmcgill/McHacks-Registration
that referenced
this pull request
Dec 21, 2017
Change email addresses to placeholders
jtviolet
pushed a commit
to jtviolet/fountain
that referenced
this pull request
Aug 13, 2019
Change email addresses to placeholders
jtviolet
pushed a commit
to jtviolet/fountain
that referenced
this pull request
Aug 13, 2019
Change email addresses to placeholders
pshirlyn
pushed a commit
that referenced
this pull request
Jan 28, 2020
Documentation for Dependabot
koroket
pushed a commit
to koroket/weddingreg
that referenced
this pull request
Aug 15, 2022
Documentation for Dependabot
koroket
pushed a commit
to koroket/weddingreg
that referenced
this pull request
Sep 19, 2022
Documentation for Dependabot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #26