Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Patch #10

Merged
merged 3 commits into from
Mar 26, 2017
Merged

Security Patch #10

merged 3 commits into from
Mar 26, 2017

Conversation

revalo
Copy link
Collaborator

@revalo revalo commented Mar 25, 2017

Summary in ATTACKS.md

No need to merge the summary markdown.

@jlin816
Copy link
Contributor

jlin816 commented Mar 26, 2017

Awesome, thanks for your work Shreyas! 👍 Just remove the summary and we're good to go (might be better to just describe the changes in the PR itself next time?)

@revalo
Copy link
Collaborator Author

revalo commented Mar 26, 2017

Yeah, I was just documenting stuff in markdown for my own tracking. Will do that next time!
Just committed the deletion.

Thanks :)

@jlin816 jlin816 merged commit c1a2d12 into techx:develop Mar 26, 2017
@anishathalye
Copy link
Contributor

Not sure if this was intentional, but you just merged three commits, where two of them are fixes and then the last one removes the ATTACKS.txt. So it's still in the Git history.

(Different people have different styles, but I generally ask people to squash before merging pull requests.)

@revalo
Copy link
Collaborator Author

revalo commented Mar 26, 2017

Ahh, that's my bad.

jtviolet referenced this pull request in jtviolet/fountain Aug 13, 2019
jtviolet referenced this pull request in jtviolet/fountain Aug 13, 2019
Daniel-Ev-Esc pushed a commit to Daniel-Ev-Esc/quill_pruebas that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants