refactor: improve GitHub API interactions and error handling #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgofx
force-pushed
the
17-refactor-github-workflow-to-separate-context-and-input-configuration
branch
30 times, most recently
from
9dd0138 to
5e68751
Compare
virgofx
force-pushed
the
17-refactor-github-workflow-to-separate-context-and-input-configuration
branch
20 times, most recently
from
c572917 to
70e4cd6
Compare
virgofx
changed the title
virgofx
force-pushed
the
17-refactor-github-workflow-to-separate-context-and-input-configuration
branch
from
70e4cd6 to
c036117
Compare
This commit refactors the GitHub API interactions and error handling in the codebase. The changes include: - Separating the GitHub API interactions from the shared module `github.ts` and into the purpose-specific file (e.g. tags, releases). - Improving error handling for GitHub API requests. - Adding more detailed logging for GitHub API requests. - Drop @actions/github and instantiate GitHub context and Octokit directly. This allows us to leverage proper instanceof RequestError. - Updating the README.md file to reflect the changes. Fixes #17
virgofx
force-pushed
the
17-refactor-github-workflow-to-separate-context-and-input-configuration
branch
from
c036117 to
e32668f
Compare
Release PlanNo terraform modules updated in this pull request.
|
virgofx
deleted the
17-refactor-github-workflow-to-separate-context-and-input-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the GitHub API interactions and error handling in the codebase. The changes include:
github.tsand into the purpose-specific file (e.g. tags, releases).@actions/githuband instantiating GitHub context and Octokit directly. This allows us to leverage properinstanceof RequestError.Fixes #17