-
-
Notifications
You must be signed in to change notification settings - Fork 0
✨ add key-aware decoding to the query string parser #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
4c8292f
:sparkles: add DecodeKind enum to distinguish key and value decoding …
techouse 5e70a47
:sparkles: add Objective-C bridge for DecodeKind enum
techouse 78ec2b4
:sparkles: unify key and value decoding with ScalarDecoder; deprecate…
techouse 2527692
:sparkles: add legacyDecoderBlock to ObjC bridge; update dot-in-keys …
techouse 4e315d5
:bug: fix dot-in-keys decoding to handle top-level dots and bracket d…
techouse 4957840
:white_check_mark: add comprehensive tests for dot-in-keys decoding, …
techouse 665a0fb
:white_check_mark: update charset custom decoder mock to use ScalarDe…
techouse 4be6dfa
:sparkles: add KEY/VALUE-aware decoderBlock to ObjC bridge; update Sw…
techouse aa9a6f2
:white_check_mark: add tests for decoderBlock invocation, dot-in-keys…
techouse ed2ca56
:white_check_mark: add comprehensive ObjC example tests for encoding …
techouse e11c6fa
:white_check_mark: add ObjC encode convenience tests for encodeOrNil …
techouse 918898c
:white_check_mark: add ObjC decode convenience tests for decodeOrNil,…
techouse abecdda
:white_check_mark: add ObjC async encode tests for main/off-main thre…
techouse 86b7b28
:recycle: refactor bridgeInputForEncode and bridgeUndefinedPreserving…
techouse 9b8aa01
:construction_worker: add Objective-C E2E test workflow for Xcode wit…
techouse 6bdc65e
:green_heart: remove code style check job from CI workflow and add sy…
techouse 3085853
:white_check_mark: rename DecodeOptionsInterplayTests_Parity to Decod…
techouse 70050ef
:bulb: update LegacyDecoderBlock comment to clarify preferred usage o…
techouse a442bb9
:green_heart: update ObjC E2E test workflow to use quiet xcodebuild a…
techouse a57f995
:bulb: update DecodeOptions docs to clarify dot decoding in keys and …
techouse 431dd7f
:bulb: clarify dot decoding and depth handling in key segment parsing…
techouse 0f5138f
:bug: fix cycle detection in NSDictionary bridging by ensuring path-l…
techouse 01b1c21
:bug: fix key decoding in NSDictionary bridging to handle non-AnyHash…
techouse 54af497
:white_check_mark: add assertion for error code in cyclic object enco…
techouse f0e8e52
:white_check_mark: update cyclic object encoding test to use error co…
techouse 530edb3
:bug: make DecodeKindObjC.swift property 'swift' public to fix access…
techouse 3f92e88
:white_check_mark: increase async test timeouts to 2s to improve reli…
techouse 616aa52
:white_check_mark: use QsDecodeKind enum for kind value in decoder bl…
techouse 61462af
:white_check_mark: remove unnecessary __unsafe_unretained qualifier f…
techouse fdfd551
:white_check_mark: update test comments to clarify disabled cases due…
techouse 47c9171
:fire: remove unused legacy dot-notation regex from Decoder.swift
techouse 338488a
:bug: fix query prefix stripping to only remove leading "?" before br…
techouse 72f990a
:bug: treat empty bracket keys as "0" when list parsing is disabled o…
techouse 601f404
:wastebasket: mark getDecoder(_:charset:) as deprecated in favor of d…
techouse 2ed323a
:construction_worker: add Objective-C code coverage upload and summar…
techouse 98bc59c
:bug: correctly detect bracketed empty keys with encoded brackets in …
techouse 1bc1765
:white_check_mark: fix incorrect maxDepth assertion in depthExceeded …
techouse 397322a
:bug: fix incorrect handling of seen set when encoding arrays with cy…
techouse 94111c9
:bug: fix incorrect removal of seen set entries when decoding cyclic …
techouse 22b731b
:bug: fix incorrect normalization of encoded brackets outside key sli…
techouse 867bf2c
:bulb: clarify handling of '=' after closing bracket in key splitting…
techouse 772fabe
:white_check_mark: add DecodeOptions parity tests for dot decoding an…
techouse c46aaea
:green_heart: update Codecov upload step to use absolute path and dis…
techouse 4d3316b
:green_heart: grant write permissions to actions in test workflow
techouse 294943f
:bug: fix list limit check to account for current list length when de…
techouse 6c1556c
:green_heart: improve SwiftPM symlink creation and add SPM cache for …
techouse e2c1f73
:hammer: add script to collect recent macOS crash logs and unified lo…
techouse 0f67a54
:green_heart: refactor CI crash log collection to use shared script f…
techouse 0ee4cc9
:green_heart: set 45 minute timeout for Swift and Objective-C test jo…
techouse b90d629
:green_heart: remove disable_search flag from Codecov upload step in …
techouse e2c1e0f
:hammer: skip system crash log copy if non-interactive sudo is unavai…
techouse 2bbbeeb
:hammer: limit crash log directory listing to last 200 entries and ex…
techouse 8adf5d8
:green_heart: update test workflow permissions and improve version re…
techouse fed074d
:bug: fix list limit check to correctly throw error when limit is exc…
techouse 247d662
:bug: ensure custom decoder preserves element-level nils as NSNull in…
techouse 8768290
:bulb: clarify behavior of numeric entity interpretation for comma-jo…
techouse 2d98abf
:green_heart: zip .xcresult directory and extract coverage JSON for i…
techouse a84b95e
:green_heart: remove verbose logging and file listing from Objective-…
techouse 3a79386
:green_heart: use dedicated derived data path for Objective-C tests a…
techouse d7023b6
:green_heart: refresh symlink if target differs and improve artifact …
techouse 7b5c6ab
:green_heart: remove unnecessary actions:write permission from test w…
techouse 853a326
:green_heart: cache SwiftPM artifacts in CI and improve symlink remov…
techouse 3c1b9df
:green_heart: remove unnecessary actions:read permission from test wo…
techouse 9c87640
:green_heart: refuse to remove non-symlink test artifacts and disable…
techouse 7f5197c
:green_heart: remove unnecessary ls command from Objective-C test wor…
techouse f78aa9a
:green_heart: set fetch-depth to 0 for full git history and cache add…
techouse 3e89fb2
:green_heart: remove debug coverage summary step from Objective-C tes…
techouse 08c384e
:green_heart: improve macOS test bundle signing and add automatic ret…
techouse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.