Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies required by democratic-csi #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roeidalm
Copy link

This PR adds the required packages to support Democratic CSI.
The following packages are installed:

libnfs-utils

nfs-common

These packages are required to enable proper NFS client functionality needed by Democratic CSI.

This commit introduces tasks to install `libnfs-utils` and `nfs-common` using the apt package manager, ensuring they are present and the package cache is updated.
Copy link
Contributor

@timothystewart6 timothystewart6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@timothystewart6
Copy link
Contributor

While looking at this some more, I can see how it's useful for those needing these dependencies but not sure that it fits into the requirements for installing k3s. Adding this would set the precedent for other post k3s configuration and storage provider dependencies.

@roeidalm
Copy link
Author

Hey, thanks for your reply!
Maybe I could add these packages conditionally, based on a value in the values.yaml, so they’re only installed if someone explicitly needs Democratic CSI? That way, it wouldn’t affect the default installation and keeps it optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants