Skip to content

apply component setttings classes for Card #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Conversation

lnhua
Copy link
Contributor

@lnhua lnhua commented May 14, 2025

There are 4 classes in Card:

  export let classes: {
    root?: string;
    header?: ComponentProps<Header>['classes'];
    headerContainer?: string;
    content?: string;
    actions?: string;
  } = {};

but only root is applied.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented May 14, 2025

🦋 Changeset detected

Latest commit: ecda00d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-ux Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 14, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
svelte-ux ✅ Ready (View Log) Visit Preview 130d18c

Copy link

pkg-pr-new bot commented May 14, 2025

Open in StackBlitz

npm i https://pkg.pr.new/svelte-ux@590

commit: 130d18c

Copy link
Owner

@techniq techniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lnhua. I added a quick example to the bottom of the Card docs and also created a changeset (pnpm changeset) so this will be picked up in the CHANGELOG and bump the version for publishing.

@techniq techniq merged commit dc0f742 into techniq:main May 14, 2025
@github-actions github-actions bot mentioned this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants