Skip to content

[SelectField] Standardize with MenuField / general improvements #132

Closed
@techniq

Description

@techniq

Extracted from PR #130

  • Use same Options type instead of any
    • Will use label instead of name by default (can still be overwritten by optionText(), maybe we call this optionLabel(), or maybe we require the data to be processed ahead of time and remove this and optionValue()
  • Pass icon prop to MenuItem like MenuField
  • Should we update the <SelectField icon={...} /> based on the selected <MenuItem icon={...} />?
    • Add a prop to opt-in to this functionality (activeOptionIcon or something)
    • Require the user to do this (like the SelectField example currently does.
  • Fix clicking on Chevon icon/button to close (re-toggles open) ([SelectField] Clicking chevron arrow re-opens menu #93)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions