Skip to content

delay mod loading for compatability #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nordgaren
Copy link

So far this has worked as expected. Will keep looking for test subjects to check all the mods, if I can.

@Nordgaren
Copy link
Author

Nordgaren commented Jun 9, 2023

Confirmed by at-least one player to be working:

fps
skip intro
chroma
vignette
Animation
and FOV

All but ultrawide

@Nordgaren
Copy link
Author

But for some reason, the anti flashbang window doesn't work for the skiptheintro mod, which I didn't patch. Maybe something you tried since cause it to bug out?

@ividyon
Copy link

ividyon commented Jul 11, 2023

also works for me and for altimor

@EzioTheDeadPoet
Copy link

@Nordgaren have you considered uploading the compiled binaries that are compatible with ModEngine2 on Nexus or your GitHub Fork since the mods here are published under a MIT license.
Because it would be within the rules of the license (if you provide the proper credit and pack the license with the files).
That way you could make it easier for people trying to "clean" mod their game to get those mods running.

I myself have ModEngine2 configured in a way where each mod is in a separate folder outside of the in this case literal "Game"-folder. But it took me a while to figure out why sometimes it was working for the mods of this repo and other times it wasn't. Getting this released as an update on nexus that puts the OG mods as "dependencies" you might help some clean-modding fanatics like myself. :D

(License wise I could release it as well but I would feel bad about it since I didn't discover the issue and based on this PR I would assume you are the one that found this fix.)

@EzioTheDeadPoet
Copy link

Also I used https://github.com/gixxpunk/EldenRingMods this fork to build the DLL files and with that fork even the skip intro mod works (when the .dll and it's mod folder are listed first in the ModEngine2 .toml file.)

@EzioTheDeadPoet
Copy link

Fixes #15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants